Skip to content

Conversation

dhoeben
Copy link
Contributor

@dhoeben dhoeben commented Aug 13, 2025

Proposed change

Added the scene to the tile card feature.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@timmo001
Copy link
Member

Make sure to run prettier also

@karwosts
Copy link
Member

Should we update the default text as well per domain? "Press" doesn't maybe seem like the right fit for a scene.

@dhoeben
Copy link
Contributor Author

dhoeben commented Aug 13, 2025

@karwosts you want to go to something like [%key:ui::card::tile::button::press%] or something else? Because I suggested activate, like the button entity row, but someone else just suggested Turn on.

@karwosts
Copy link
Member

turn_on is the service that is called when you press it. Not the text of the button.

There is no service called scene.activate, that's why that suggestion was made.

@dhoeben
Copy link
Contributor Author

dhoeben commented Aug 13, 2025

turn_on is the service that is called when you press it. Not the text of the button.

There is no service called scene.activate, that's why that suggestion was made.

A my mistake. I use a script which is called like that, sorry for the misunderstanding.

@silamon silamon marked this pull request as draft August 14, 2025 17:32
@dhoeben dhoeben marked this pull request as ready for review August 20, 2025 12:23
@bramkragten bramkragten marked this pull request as draft August 25, 2025 12:17
@bramkragten
Copy link
Member

Converted to draft, please address the requested changes and mark as ready for review when done 👍

@bramkragten bramkragten marked this pull request as ready for review August 25, 2025 13:08
@bramkragten bramkragten enabled auto-merge (squash) August 25, 2025 13:10
@bramkragten bramkragten merged commit bc7533b into home-assistant:dev Aug 25, 2025
11 checks passed
@dhoeben
Copy link
Contributor Author

dhoeben commented Aug 26, 2025

Thanks @bramkragten & @MindFreeze!

@dhoeben dhoeben deleted the tile-button branch August 26, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants