Skip to content

Conversation

wendevlin
Copy link
Contributor

Proposed change

  • automation sidebar
    • when open sidebar via keyboard, we focus the sidebar to have a fluent navigation

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The outline still should be hidden when focused.

ha-automation-sidebar {
  outline: none;
}

Also, can we focus the row when the sidebar is closed? 😅

@wendevlin
Copy link
Contributor Author

The outline still should be hidden when focused.

ha-automation-sidebar {
  outline: none;
}

Also, can we focus the row when the sidebar is closed? 😅

I'll try

@silamon silamon marked this pull request as draft August 21, 2025 17:06
@wendevlin
Copy link
Contributor Author

@piitaya sorry I wasn't able to refocus when closing. Actually it should work but I don't know why and don't want to invest too much time now. But I'll keep it in miind

@wendevlin wendevlin marked this pull request as ready for review August 27, 2025 08:23
bramkragten
bramkragten previously approved these changes Aug 27, 2025
@bramkragten bramkragten enabled auto-merge (squash) August 27, 2025 11:21
@bramkragten bramkragten merged commit 8fd3fcd into dev Aug 27, 2025
11 checks passed
@bramkragten bramkragten deleted the focus-sidebar-keyboard branch August 27, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants