Skip to content

Conversation

philippwaller
Copy link
Contributor

Proposed change

Follow-up to #26613.
@MindFreeze — thanks for reviewing the previous PR. This follow-up implements the requested changes.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@Copilot Copilot AI review requested due to automatic review settings August 21, 2025 07:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the automation editor event naming for consistency by renaming the event from show-automation-editor to hass-automation-editor. This change aligns with Home Assistant's event naming conventions where events are prefixed with hass-.

Key changes:

  • Renamed the DOM event from show-automation-editor to hass-automation-editor
  • Moved the event type declaration from automation.ts to automation-editor-mixin.ts for better organization
  • Updated the event listener registration to use the new event name

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/state/automation-editor-mixin.ts Added event type declaration and updated event listener to use new hass-automation-editor event name
src/data/automation.ts Removed the old event type declaration that was moved to the mixin file

Copy link
Member

@MindFreeze MindFreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MindFreeze MindFreeze merged commit f131e93 into home-assistant:dev Aug 21, 2025
15 checks passed
@philippwaller philippwaller deleted the hass-automation-editor branch August 21, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants