Add analog card clock style options #26711
Conversation
6da771d to
14c2078
Compare
| defaulted( | ||
| union([ | ||
| literal("markers"), | ||
| literal("numbers"), |
There was a problem hiding this comment.
I'm 50/50 on having non-upright numbers here. Looks like most analog clocks with numbers keep upright, while roman numerals tend to rotate with the clock.
The upright and standard rotated option visually looks ok for the roman numeral case though
There was a problem hiding this comment.
And 6 looks like 9 when it's non-upright ...
There was a problem hiding this comment.
Yeah that is the main one, It doesn't look too bad with hours/minutes ticks side by side with roman numeral cards, but as quarters looks off
|
We have to watch out to not introduce too many options... |
Co-authored-by: Norbert Rittel <norbert@rittel.de>
Show lines Adjust Adjust Replace 'ticks_style' with 'face_style' and use numbers over numeric Use numbers over numeric
1826329 to
fe229b8
Compare
|
Looking for feedback on this one. Especially the options, whether numbers should be always upright or allow for both. Based on my deep dive into clocks, most roman numeral clocks rotate with the face, but base 10 numbers are generally always upright I think this will probably be the last option for analog clock, I think everything else could be done via theming potentially |
Breaking change
Proposed change
Builds on #26557
Adds a few face style options
New options side by side (Medium size, hour ticks):
Mixed with other options:
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: