Skip to content

Add binary_sensor to UISP airOS #40242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 9, 2025
Merged

Add binary_sensor to UISP airOS #40242

merged 8 commits into from
Aug 9, 2025

Conversation

CoMPaTech
Copy link
Contributor

@CoMPaTech CoMPaTech commented Aug 1, 2025 •
edited
Loading

Proposed change

Add binary sensors to airOS

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • [] Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Aug 1, 2025
@netlify Netlify
Copy link

netlify bot commented Aug 1, 2025 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 71f3079
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/68923fd91f1b20000964b393
😎 Deploy Preview https://deploy-preview-40242--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@CoMPaTech CoMPaTech mentioned this pull request Aug 1, 2025
Merged
19 tasks
@CoMPaTech
Copy link
Contributor Author

CoMPaTech commented Aug 1, 2025 •
edited
Loading

Probably needs rebase since #40199 is not merged (yet)

c0ffeeca7
c0ffeeca7 requested changes Aug 4, 2025
View reviewed changes
@home-assistant home-assistant bot marked this pull request as draft August 4, 2025 07:38
@home-assistant
Copy link

home-assistant bot commented Aug 4, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@CoMPaTech CoMPaTech marked this pull request as ready for review August 4, 2025 07:48
@home-assistant home-assistant bot requested a review from c0ffeeca7 August 4, 2025 07:48
c0ffeeca7
c0ffeeca7 reviewed Aug 4, 2025
View reviewed changes
@CoMPaTech CoMPaTech marked this pull request as draft August 4, 2025 07:58
c0ffeeca7
c0ffeeca7 previously approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @CoMPaTech 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Aug 4, 2025
@c0ffeeca7 c0ffeeca7 marked this pull request as ready for review August 4, 2025 08:06
@Copilot Copilot AI review requested due to automatic review settings August 4, 2025 08:06
@home-assistant home-assistant bot requested a review from c0ffeeca7 August 4, 2025 08:06
Copilot
Copilot AI reviewed Aug 4, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the airOS integration documentation by adding comprehensive binary sensor documentation and clarifying device operating modes. The changes provide users with better understanding of device capabilities and network configuration options.

  • Adds detailed binary sensor documentation with five new sensor types
  • Introduces operating roles section explaining Access Point vs Station modes and Bridge vs Router configurations
  • Updates supported devices section with improved formatting and community feedback encouragement
Comments suppressed due to low confidence (1)

source/_integrations/airos.markdown:58

  • The link reference '#feedback_section' appears to be incorrect as there is no corresponding section with that anchor in the document.
Do you have a device that works? We’d love to hear [your experience](#feedback_section) so we can add it to this list!

c0ffeeca7
c0ffeeca7 previously approved these changes Aug 4, 2025
View reviewed changes
@CoMPaTech
Copy link
Contributor Author

Shouldn't we abbr NAT as well @c0ffeeca7?

@CoMPaTech
Copy link
Contributor Author

Will add to my todo list to check the other text for consistency as well

@c0ffeeca7
Copy link
Contributor

Shouldn't we abbr NAT as well @c0ffeeca7?

ah, yes!

@CoMPaTech CoMPaTech requested a review from c0ffeeca7 August 4, 2025 08:15
c0ffeeca7
c0ffeeca7 previously approved these changes Aug 4, 2025
View reviewed changes
CoMPaTech and others added 3 commits August 5, 2025 19:29
@CoMPaTech
Add binary_sensor and mode explanations
606002f
@CoMPaTech
Update with code
4dce08e
@CoMPaTech @c0ffeeca7
Apply suggestions from code review
453b389 
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
CoMPaTech and others added 5 commits August 5, 2025 19:29
@CoMPaTech @c0ffeeca7
Apply suggestions from code review
7e65fc5 
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
@c0ffeeca7 @Copilot @CoMPaTech
Update source/_integrations/airos.markdown
8359da7 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@c0ffeeca7 @Copilot @CoMPaTech
Update source/_integrations/airos.markdown
17dff84 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@CoMPaTech
Add NAT abbr
4fe8ae1
@CoMPaTech
Remove non-binary parts
71f3079
@CoMPaTech
Copy link
Contributor Author

CoMPaTech commented Aug 5, 2025 •
edited
Loading

@c0ffeeca7 removed the non-binary part things (including the abbr suggestions to another PR #40289 to make merging cleaner

@CoMPaTech CoMPaTech mentioned this pull request Aug 5, 2025
Merged
8 tasks
@CoMPaTech CoMPaTech changed the title Add binary_sensor and mode explanations to UISP airOS Add binary_sensor to UISP airOS Aug 5, 2025
@home-assistant home-assistant bot added the parent-merged The parent PR has been merged already label Aug 8, 2025
@c0ffeeca7 c0ffeeca7 merged commit 5f271ee into home-assistant:next Aug 9, 2025
7 checks passed
@home-assistant home-assistant bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Aug 9, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@c0ffeeca7 c0ffeeca7 c0ffeeca7 approved these changes

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in another repo next This PR goes into the next branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CoMPaTech @c0ffeeca7