-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Update adguard.markdown #40301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Update adguard.markdown #40301
Conversation
Add some extra information about using port 80 when the web interface is not using port 3000. This should answer a number of queries that have come up on the forum.
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Username: | ||
description: "Your AdGuard Home admin username." | ||
Password: | ||
description: "Your AdGuard Home admin password." | ||
Verify SSL certificate: | ||
description: "Enable SSL certificate verification when connecting via HTTPS." | ||
description: "Enable SSL certificate verification when connecting via HTTPS. Untick, if using port `80`." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't have to be correct. Port isn't related to having HTTP or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Port 80 wouldn't work for me with the SSL boxes ticked. My instance of AdGuard Home is http, so I couldn't test what happens with port 443.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Port 80 wouldn't work for me with the SSL boxes ticked.
That isn't related to port, that is related to if your service (in this case AdGuard) is running with SSL termination on that port or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I thought port 80 meant unsecure and 443 meant secure. I'm at my limit of understanding here :) so I'll leave it up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought port 80 meant unsecure and 443 meant secure.
That is a common pattern used, yes. But not a given factor.
@@ -35,13 +35,13 @@ Before setting up the AdGuard Home integration, ensure you have: | |||
Host: | |||
description: "The IP address or hostname of your AdGuard Home instance. For example: `192.168.1.100` or `adguard.local`." | |||
Port: | |||
description: "The port AdGuard Home is running on. Default is `3000` for the web interface." | |||
description: "The port AdGuard Home is running on. Default is `3000` for the web interface. If your web interface does not show a port, enter `80`." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we adjust the UI of Home Assistant (set up flow) instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what flow is, sorry, but if it means that the user gets stepped through a series of questions which removes some of the guess work, that would be a great outcome.
Add some extra information about using port 80 when the web interface is not using port 3000. This should answer a number of queries that have come up on the forum.
Proposed change
Updated the documentation about using port 80 where the web interface does not use port 3000. This tripped me up when adding the integration and I came across a number posts on the forum and Reddit asking about this exact issue.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.