Skip to content

Bump nvmrc version to node 20 LTS, matching workflows #40517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 35 commits into from
Closed

Bump nvmrc version to node 20 LTS, matching workflows #40517

wants to merge 35 commits into from

Conversation

timmo001
Copy link
Member

@timmo001 timmo001 commented Aug 20, 2025 •
edited
Loading

Proposed change

Type of change

Bumps the nvmrc file to match the node version used in the workflows to stop the prompt for installing node 18 when I enter the directory in my environment.

Looks like node18 is being used to build in netlify but it could be different at runtime

https://nodejs.org/en/about/previous-releases

This could potentially go up to node 22 LTS

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

CoMPaTech and others added 30 commits July 30, 2025 17:38
@CoMPaTech
Improve introduction and add use-case and example for UISP airOS (#40210
f9a9929 
)
@Petro31
Add-optimistic-to-platforms (#40235)
659de7e
@fabiandev @c0ffeeca7
Linked entities for HomeKit valve duration characteristics (#40222)
ddc7ba8 
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
@CoMPaTech
Add diagnostics section to UISP AirOS (#40199)
3c328f8
@astrandb
Add automation example to Miele page (#40231)
f57d135
@thomasddn
Add sensor to Qbus integration (#40130)
f05adb5
@tr4nt0r
Add direct message notifier to PlayStation Network (#40249)
1901cb8
@jpbede
Add jitter sensor to Ping integration (#40259)
c9ef979
@hanwg
Update Telegram bot events (#39983)
c142c25
@Taraman17
Add zeroconf to Homee (#40246)
0ef5b25
@Thomas55555
Reset cutting blade usage time in Husqvarna Automower (#40260)
ef1aeb7
@CoMPaTech
Remove airOS wireless_mode sensor (#40274)
a2fa2bd
@CoMPaTech
Improve airOS documentation (#40289)
c33a070
@starkillerOG
Reduce Reolink fimware polling from 12h to 24h docs (#40299)
df3962a
@jbouwh
Deprecate MQTT vacuum battery feature (#40251)
b960a35
@tronikos
Update Opower for PG&E (#40211)
b2af373
@bdraco
Add support for Inkbird IAM-T2 (#40314)
4d27161
@gjohansson-ST
Remove linear_garage_door integration docs (#40302)
df91af7
@jpelgrom
Document select platform for LetPot integration (#40323)
930312b
@MindFreeze @c0ffeeca7
Document layout: auto for "energy-sankey" card (#40322)
5d69fd1 
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
@mbo18
Add absolute humidity to Awair documentation (#40304)
b8b1717
@elupus @c0ffeeca7 @joostlek
Add ToGrill documentation (#40291)
9319084 
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@CoMPaTech @c0ffeeca7 @Copilot
Add binary_sensor to UISP airOS (#40242)
5f271ee 
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Thomas55555 @c0ffeeca7
Add event platform to Husqvarna Automower (#39863)
f97ea3b 
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
@tronikos
Remove Mercury NZ Limited from docs (#40348)
a372f49
@vincentwolsink
Add documentation for humidity control Huum (#40356)
a04a279
@dontinelli
Update solarlog documentation for new sensors (#40366)
2466b95
@karwosts
Support multiple for StateSelector (#39419)
6347e1a
@rlint-explicatis
Smarla integration doc sensor platform (#39276)
dc7c1d9
@pcan08
Add fan-direction dashboard feature documentation (#40367)
e99390a
@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Aug 20, 2025
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@netlify Netlify
Copy link

netlify bot commented Aug 20, 2025 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 295900b
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/68a58934fd729400088621f4
😎 Deploy Preview https://deploy-preview-40517--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@timmo001 timmo001 removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Aug 20, 2025
@home-assistant home-assistant bot added the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Aug 20, 2025
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@timmo001 timmo001 marked this pull request as ready for review August 20, 2025 08:56
@timmo001 timmo001 removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Aug 22, 2025
frenck
frenck requested changes Aug 27, 2025
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs targeting the current branch.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft August 27, 2025 08:28
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@timmo001 timmo001 changed the base branch from next to current August 27, 2025 08:29
@home-assistant home-assistant bot added current This PR goes into the current branch and removed next This PR goes into the next branch labels Aug 27, 2025
@timmo001
Copy link
Member Author

I'll make a new branch for this

@timmo001 timmo001 closed this Aug 27, 2025
@home-assistant home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Aug 27, 2025
@timmo001
Copy link
Member Author

#40619

@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck requested changes

@elupus elupus Awaiting requested review from elupus elupus will be requested when the pull request is marked ready for review elupus is a code owner

@Ernst79 Ernst79 Awaiting requested review from Ernst79 Ernst79 will be requested when the pull request is marked ready for review Ernst79 is a code owner

@starkillerOG starkillerOG Awaiting requested review from starkillerOG starkillerOG will be requested when the pull request is marked ready for review starkillerOG is a code owner

@jpbede jpbede Awaiting requested review from jpbede jpbede will be requested when the pull request is marked ready for review jpbede is a code owner

@tronikos tronikos Awaiting requested review from tronikos tronikos will be requested when the pull request is marked ready for review tronikos is a code owner

@jpelgrom jpelgrom Awaiting requested review from jpelgrom jpelgrom will be requested when the pull request is marked ready for review jpelgrom is a code owner

@bdraco bdraco Awaiting requested review from bdraco bdraco will be requested when the pull request is marked ready for review bdraco is a code owner

Assignees
No one assigned
Labels
current This PR goes into the current branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.