Skip to content

Add 'asset.download' API permission to Immich #40627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

Add 'asset.download' API permission to Immich #40627

merged 1 commit into from
Aug 27, 2025

Conversation

mib1185
Copy link
Member

@mib1185 mib1185 commented Aug 27, 2025

Proposed change

add a missing implicit permission, which is needed under some circumstances (for more details immich-app/immich#21035)

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@Copilot Copilot AI review requested due to automatic review settings August 27, 2025 13:39
@home-assistant home-assistant bot added the current This PR goes into the current branch label Aug 27, 2025
@netlify Netlify
Copy link

netlify bot commented Aug 27, 2025 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 38c9a48
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/68af0a7a2689490008304b5a
😎 Deploy Preview https://deploy-preview-40627--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot
Copilot AI reviewed Aug 27, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a missing API permission (asset.download) to the Immich integration documentation. The change addresses an issue where certain functionality requires this implicit permission that was not previously documented.

Key changes:

  • Added asset.download permission to the required API permissions list

@silamon silamon merged commit 1fa32f8 into current Aug 27, 2025
9 checks passed
@silamon silamon deleted the mib1185-patch-1 branch August 27, 2025 16:46
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@silamon silamon silamon approved these changes

Assignees
No one assigned
Labels
current This PR goes into the current branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

immich media browser integration returns 404s for JPEG files
2 participants
@mib1185 @silamon