Skip to content

Fix Node.js 32-bit architecture compatibility and add alpha/stable build streams with selective Node.js 24 for 64-bit #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 2, 2025
Merged

Fix Node.js 32-bit architecture compatibility and add alpha/stable build streams with selective Node.js 24 for 64-bit #172

merged 14 commits into from
Sep 2, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Sep 2, 2025 •
edited
Loading

This PR addresses the build failures that occur when Node.js 24+ is used with 32-bit architectures (ARM32/i386), which dropped 32-bit support starting with Node.js 23, and implements architecture-specific build streams for all release types (alpha, beta, stable) with strategic Node.js version deployment.

Problem

The original issue manifested as build failures when attempting to download Node.js 24 binaries for 32-bit ARM:

+ curl -SLO https://nodejs.org/dist/v24.2.0/node-v24.2.0-linux-armv7l.tar.gz
# Results in 404 - file doesn't exist because Node.js 24 doesn't support 32-bit architectures

While the build script had some logic to prevent this, the error handling was not robust enough and error messages were unclear. Additionally, only beta builds had architecture-specific configurations, limiting the ability to use consistent Node.js versions across all release types.

Solution

Enhanced Build Script Validation

  • Proactive Configuration Validation: Added early validation of package.json files with clear logging
  • Improved Error Messages: Replaced generic "skipping" messages with detailed explanations of Node.js version constraints
  • Additional Safety Checks: Added redundant validation during Node.js binary download to catch edge cases
  • Better Logging: Added emoji-based status indicators and structured logging for easier debugging

Architecture-Specific Build Streams for All Release Types

Extended the beta build pattern to all release types with strategic Node.js version deployment:

  • Alpha builds: alpha/32bit/package.json (Node.js 22) and alpha/64bit/package.json (Node.js 24)
  • Beta builds: beta/32bit/package.json (Node.js 22) and beta/64bit/package.json (Node.js 24)
  • Stable builds: stable/32bit/package.json (Node.js 22) and stable/64bit/package.json (Node.js 22)

This approach enables bleeding-edge Node.js 24 for alpha/beta 64-bit builds while maintaining stability with Node.js 22 for stable releases.

Build System Integration

  • Alpha Bot Configuration: Added .github/homebridge-alpha-bot.json for automated alpha dependency management
  • Alpha Workflows: Created alpha-stage-1 and alpha-stage-2 workflows for alpha release automation
  • Enhanced Dependabot: Separate monitoring for all three release types with appropriate Node.js constraints to prevent unwanted updates
  • Build Logic: Updated build.sh to automatically select appropriate config based on release type and target architecture

Validation Tools

  • test/validate-config.sh: Enhanced to validate all alpha, beta, and stable configurations
  • test/test-nodejs-validation.sh: Comprehensive test suite covering all build streams and validation scenarios

Documentation Improvements

  • README.md: Updated architecture support section to clearly indicate Node.js version limitations
  • build.sh: Added comprehensive header documentation explaining constraints and usage for all release types
  • BUILD.md: Complete package configuration structure documentation

Key Changes

  1. Error Handling: Build now fails fast with clear, actionable error messages when Node.js >22 is attempted on 32-bit architectures
  2. Package Selection: Robust validation ensures correct package.json selection based on release type and architecture
  3. Download Safety: Additional checks prevent attempting to download non-existent Node.js binaries
  4. Testing: Comprehensive test coverage for all validation scenarios across alpha, beta, and stable
  5. Release Type Support: All three release types (alpha, beta, stable) now have architecture-specific configurations
  6. Strategic Node.js Deployment:
    • Alpha/Beta 64-bit: Node.js 24 for cutting-edge development
    • Stable 64-bit: Node.js 22 for production stability
    • All 32-bit: Node.js 22 (due to Node.js 24+ dropping 32-bit support)
  7. Dependabot Configuration: Fixed missing Node.js version constraints for stable 64-bit stream to prevent automatic updates beyond Node.js 22
  8. Test Organization: Moved validation scripts to test/ directory for better project organization

Validation

All tests pass successfully, confirming:

  • ✅ Current package configurations are valid for all release types (alpha, beta, stable)
  • ✅ Node.js >22 correctly blocked on 32-bit architectures with clear error messages
  • ✅ Node.js 24 used for alpha/beta 64-bit builds, Node.js 22 for stable and all 32-bit builds
  • ✅ Build script syntax and logic validation for all release types
  • ✅ Alpha, beta, and stable build streams properly configured and tested
  • ✅ Dependabot properly configured to prevent Node.js updates beyond supported versions for stable releases

The fix ensures that the download failures described in the original issue cannot occur while providing clear guidance when misconfigurations are detected. The architecture-specific build streams enable strategic Node.js version deployment across all release types while maintaining compatibility for 32-bit systems and enabling cutting-edge development for alpha/beta releases.

Fixes #82.

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI and others added 2 commits September 2, 2025 14:05
@Copilot @NorthernMan54
Add robust Node.js version validation and improved error handling for…
c685288 
… 32-bit builds

Co-authored-by: NorthernMan54 <19808920+NorthernMan54@users.noreply.github.com>
@Copilot @NorthernMan54
Add comprehensive testing and documentation for Node.js 32-bit suppor…
703e395 
…t constraints

Co-authored-by: NorthernMan54 <19808920+NorthernMan54@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] NodeJS 24 removes support for 32 Bit environments Fix Node.js 24 32-bit architecture compatibility issues with enhanced validation Sep 2, 2025
@Copilot Copilot AI requested a review from NorthernMan54 September 2, 2025 14:10
Copilot finished work on behalf of NorthernMan54 September 2, 2025 14:10
@NorthernMan54
Copy link
Contributor

@copilot Pls create two build streams for the stable release package, similar to how the beta stream is doing the same with the 32bit and 64bit package.json files.

@Copilot @NorthernMan54
Create stable build streams with architecture-specific configurations
4287cc6 
- Add stable/32bit/ and stable/64bit/ directories with package.json configs
- Update build.sh to use architecture-specific configs for stable builds
- Update validation and test scripts to handle new stable configurations
- Update Dependabot config to monitor new stable package.json files
- Update BUILD.md with package configuration documentation
- Update workflows to trigger on stable package.json changes

Co-authored-by: NorthernMan54 <19808920+NorthernMan54@users.noreply.github.com>
@Copilot Copilot SWE Agent
Copy link
Contributor Author

Copilot AI commented Sep 2, 2025

@copilot Pls create two build streams for the stable release package, similar to how the beta stream is doing the same with the 32bit and 64bit package.json files.

I've created two build streams for the stable release package, similar to the beta stream structure:

New Structure:

  • stable/32bit/package.json - Node.js 22.x for ARM32/i386 architectures
  • stable/64bit/package.json - Node.js 24.x for x86_64/aarch64 architectures

Key Changes:

  • Updated build.sh to automatically select the appropriate config based on target architecture
  • Enhanced Dependabot configuration to monitor both stable streams separately
  • Updated workflows to trigger on changes to any stable package.json file
  • Added comprehensive validation and testing for the new structure

This provides the same architecture-specific benefits as the beta streams while ensuring Node.js version compatibility constraints are properly maintained. Commit: 4287cc6

@Copilot Copilot AI changed the title Fix Node.js 24 32-bit architecture compatibility issues with enhanced validation Fix Node.js 24 32-bit architecture compatibility issues and add stable build streams Sep 2, 2025
Copilot finished work on behalf of NorthernMan54 September 2, 2025 14:24
@NorthernMan54
Copy link
Contributor

@copilot Pls fix conflicts with build.sh

@NorthernMan54
Copy link
Contributor

@copilot At this time, pls keep the 64bit stream on NodeJS 22. Launch of NodeJS will be in the future

@Copilot @NorthernMan54
Fix build.sh conflicts by adding alpha support and merging with lates…
f81cbdf 
…t branch changes

Co-authored-by: NorthernMan54 <19808920+NorthernMan54@users.noreply.github.com>
@Copilot Copilot SWE Agent
Copy link
Contributor Author

Copilot AI commented Sep 2, 2025

@copilot Pls fix conflicts with build.sh

Fixed the build.sh conflicts by adding alpha support from the latest branch. The conflict occurred because the latest branch added alpha release type support while my changes added stable build streams. I've now merged both features:

Changes made:

  • Added alpha build streams (alpha/32bit, alpha/64bit) with appropriate Node.js versions
  • Updated build.sh to handle alpha, beta, and stable release types with architecture-specific configs
  • Added alpha bot configuration and workflows
  • Updated validation and testing scripts to include alpha configurations

All three release types now work correctly:

  • Alpha: Uses alpha/64bit (Node.js 24) for x86_64/aarch64, alpha/32bit (Node.js 22) for arm/i386
  • Beta: Uses beta/64bit (Node.js 24) for x86_64/aarch64, beta/32bit (Node.js 22) for arm/i386
  • Stable: Uses stable/64bit (Node.js 24) for x86_64/aarch64, stable/32bit (Node.js 22) for arm/i386

Commit: f81cbdf

@Copilot Copilot AI changed the title Fix Node.js 24 32-bit architecture compatibility issues and add stable build streams Fix Node.js 24 32-bit architecture compatibility and add alpha/stable build streams Sep 2, 2025
Copilot finished work on behalf of NorthernMan54 September 2, 2025 14:40
@Copilot @NorthernMan54
Update all 64-bit build streams to use Node.js 22 instead of Node.js 24
6652ed0 
Co-authored-by: NorthernMan54 <19808920+NorthernMan54@users.noreply.github.com>
@Copilot Copilot SWE Agent
Copy link
Contributor Author

Copilot AI commented Sep 2, 2025

@copilot At this time, pls keep the 64bit stream on NodeJS 22. Launch of NodeJS will be in the future

Updated all 64-bit build streams to use Node.js 22.19.0 instead of Node.js 24. The changes affect:

  • stable/64bit/package.json
  • alpha/64bit/package.json
  • beta/64bit/package.json

All configurations now use Node.js 22 across both 32-bit and 64-bit architectures. Node.js 24 launch can be implemented in the future when ready. Commit: 6652ed0

@Copilot Copilot AI changed the title Fix Node.js 24 32-bit architecture compatibility and add alpha/stable build streams Fix Node.js 32-bit architecture compatibility and add alpha/stable build streams with Node.js 22 Sep 2, 2025
Copilot finished work on behalf of NorthernMan54 September 2, 2025 14:44
@NorthernMan54
Copy link
Contributor

@copilot For beta and alpha 64 bit streams, pls use NodeJS 24

@Copilot @NorthernMan54
Update beta and alpha 64-bit streams to use Node.js 24
4383554 
Co-authored-by: NorthernMan54 <19808920+NorthernMan54@users.noreply.github.com>
@Copilot Copilot SWE Agent
Copy link
Contributor Author

Copilot AI commented Sep 2, 2025

@copilot For beta and alpha 64 bit streams, pls use NodeJS 24

Updated beta and alpha 64-bit streams to use Node.js 24.12.0. The 32-bit streams remain on Node.js 22.19.0 since Node.js 24+ dropped 32-bit support. All configuration validations pass successfully. Commit: 4383554

@Copilot Copilot AI changed the title Fix Node.js 32-bit architecture compatibility and add alpha/stable build streams with Node.js 22 Fix Node.js 32-bit architecture compatibility and add alpha/stable build streams with selective Node.js 24 for 64-bit Sep 2, 2025
Copilot finished work on behalf of NorthernMan54 September 2, 2025 14:50
@NorthernMan54
Copy link
Contributor

@copilot dependabot config is missing the ignore for 64bit NodeJS versions.

@Copilot @NorthernMan54
Add missing Node.js version ignore for stable 64-bit Dependabot config
27c342d 
Co-authored-by: NorthernMan54 <19808920+NorthernMan54@users.noreply.github.com>
@Copilot Copilot SWE Agent
Copy link
Contributor Author

Copilot AI commented Sep 2, 2025

@copilot dependabot config is missing the ignore for 64bit NodeJS versions.

Added the missing Node.js version ignore rule for stable 64-bit stream. The Dependabot configuration now correctly prevents automatic updates to Node.js >22.x for all stable builds (32-bit, 64-bit, and legacy), ensuring stable releases stay on Node.js 22 as requested. Commit: 27c342d

Copilot finished work on behalf of NorthernMan54 September 2, 2025 15:05
@NorthernMan54
Copy link
Contributor

@copilot move test-nodes-validation and validate-config to the test directory

Also when should these be used ?

@Copilot @NorthernMan54
Move validation scripts to test directory
11a298a 
Co-authored-by: NorthernMan54 <19808920+NorthernMan54@users.noreply.github.com>
@Copilot Copilot SWE Agent
Copy link
Contributor Author

Copilot AI commented Sep 2, 2025

@copilot move test-nodes-validation and validate-config to the test directory

Also when should these be used ?
...

Moved both scripts to the test directory. Commit: 11a298a

When to use these scripts:

test/validate-config.sh - Run this to validate package configurations:

  • Before making changes to any package.json files in alpha/, beta/, or stable/ directories
  • After updating Node.js versions to ensure 32-bit compatibility (Node.js ≤22)
  • As part of pre-commit validation to catch configuration issues early
  • When troubleshooting build failures

test/test-nodejs-validation.sh - Run this for comprehensive testing:

  • After making changes to build.sh validation logic
  • When adding new release types or architecture configurations
  • Before major releases to verify all validation scenarios work correctly
  • To test error handling for Node.js version constraints

Both scripts run quickly (< 30 seconds) and provide clear validation feedback with detailed error messages when issues are found.

Copilot finished work on behalf of NorthernMan54 September 2, 2025 15:26
@NorthernMan54 NorthernMan54 moved this to Done in NodeJS 24 Sep 2, 2025
@NorthernMan54 NorthernMan54 marked this pull request as ready for review September 2, 2025 15:29
@NorthernMan54 NorthernMan54 merged commit b530206 into latest Sep 2, 2025
5 checks passed
@NorthernMan54 NorthernMan54 deleted the copilot/fix-82 branch September 2, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwp91 bwp91 Awaiting requested review from bwp91 bwp91 is a code owner

@donavanbecker donavanbecker Awaiting requested review from donavanbecker donavanbecker is a code owner

1 more reviewer

@NorthernMan54 NorthernMan54 NorthernMan54 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@NorthernMan54 NorthernMan54

Copilot code review Copilot

Labels
None yet
Projects
NodeJS 24
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NodeJS 24 removes support for 32 Bit environments
2 participants
@Copilot @NorthernMan54