Use AST token constants from token module. #14701
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After Python 3.7 all tokens are available in both `token` and `tokenize` modules in tokenize's doc > All constants from the token module are also exported from tokenize. See python/cpython@fc354f0 and https://mail.python.org/pipermail/python-dev/2017-May/148080.html
|
I'm also not a big fan of now having to import both token and tokenize, but I can live with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm lukewarm on this change, it's nice for all the constants to use the same namespace but it's ugly to have to change the
for token in tokensloops.After Python 3.7 all tokens are available in both
tokenandtokenizemodulesin tokenize's doc
See python/cpython@fc354f0 and https://mail.python.org/pipermail/python-dev/2017-May/148080.html