Skip to content

Fix deduperreload file name in tracebacks #14945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jaysarva
Copy link
Contributor

@jaysarva jaysarva commented Jul 23, 2025

This is a half-fix for tracebacks in deduperreload -- filenames are now properly shown in the traceback. Part 1 of fix to #14900
Line numbers are still not rendered, but we hope to send a fix for this in the future.

@jaysarva
Copy link
Contributor Author

cc @smacke

@smacke
Copy link
Contributor

smacke commented Jul 29, 2025

Thanks for adding this @jaysarva ! Not going to ping Mike since I imagine he's busy and this is not time sensitive, but for when he does see this: I fully vouch for this change as a solid partial fix for tracebacks getting messed up in deduper-reloaded modules (with more improvements to come for line numbers).

@krassowski krassowski added this to the 9.5 milestone Aug 5, 2025
@krassowski
Copy link
Member

Thank you @jaysarva - could you add a test for it?

@krassowski
Copy link
Member

Just checking back here - if you do not have anything locally I could help with the test - let me know.

@jaysarva
Copy link
Contributor Author

Hi @krassowski I'm almost done with a more complete fix (just testing to make sure there's no bugs right now).
it might be reasonable to just directly look at that instead of adding this incremental fix. hope to put it out in the next week or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants