ignore the assert statement's conditional branch. (#1378) #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
before fix: |
|
An alternative solution to AssertFilter: 62
results in this report, where they're not even considered coverage lines: |
|
I love that |
|
Going to bump this and see if we can get it looked at and merged? This has been the main reason why our team hasn't migrated off of clover. |
|
Does anyone know why the JDK 21 and 22 builds failed for this PR? Can somebody trigger the builds again? The failed builds no longer exist on Azure, so there's no telling what happened, AFAICT. |
|
This would be really nice to have! |
|
I opened #1816. All tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert statement coverage should be considered complete if the assert statement was visited. There's no need to track multiple branches at the assert statement.
This is in agreement with the previously reported issue #324, which suggested "They should not be treated as code instructions."
I've extended the ignored instructions to include the assert statement check. This will make coverage complete with or without assertions enabled.