List Support for SQL IN Clause #434
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oshai can you help me with this? What do I have to fix? |
I just rerun it, hth. |
|
@oshai Thx. Please review my code then.😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for List encoding and resolves mapping issues when using ArrayList with SQL IN clauses.
Key Changes
Added ListEncoder Support in BinaryRowEncoder - Enables conversion of List types to MySQL length-encoded comma-separated strings
Created ListEncoder Tests - Comprehensive test suite verifying various list encoding scenarios (empty lists, single/multiple items, null filtering, etc.)
Implemented ArrayListInClause Tests - Demonstrates the issue with ArrayList in SQL IN clauses and provides two solutions:
Using correct SQL placeholders
Related Issue
#289