Proposal -- Update PULL_REQUEST_TEMPLATE.md #3105
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is a short proposal for #3104 . I don't want it to be overly rigid/bureaucratic or otherwise get in the way. Instead, just act as a reminder for common things to look out for (e.g., ensuring that changes to one solver have been made in all solvers to keep them in sync where possible). Comments/changes/objections/alternative proposals etc. are all appreciated!
|
Ah, I put only the issue number there because I didn't want to put up a hurdle for people wanting to contribute something. be thankful that they do, is the reasoning :-) The issue number, when mentioned, is automatically linked, so that the issue gets closed when the PR gets closed. Nice! |
Merged
Readd "Fixes #9999"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a short proposal for #3104 .
I don't want it to be overly rigid/bureaucratic or otherwise get in the way.
Instead, just act as a reminder for common things to look out for (e.g., ensuring that changes to one solver have been made in all solvers to keep them in sync where possible).
Comments/changes/objections/alternative proposals etc. are all appreciated!