Add structure support for Java 22, 23 and 24 (no features) #4769
+190
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 2, 2025 10:48
(cherry picked from commit c8e0872b26cdc6a61d6d520defe91c06115a252f)
martinaldrin
reviewed
Jun 2, 2025
| @@ -20,7 +20,7 @@ | |||
| package com.github.javaparser.ast.validator.language_level_validations; | |||
|
|
|||
| /** | |||
| * This validator validates according to Java 21 syntax rules. | |||
| * This validator validates according to Java 24 syntax rules. | |||
| * | |||
| * @see <a href="https://openjdk.java.net/projects/jdk/21/">https://openjdk.java.net/projects/jdk/21/</a> | |||
martinaldrin
reviewed
Jun 2, 2025
| @@ -20,7 +20,7 @@ | |||
| package com.github.javaparser.ast.validator.language_level_validations; | |||
|
|
|||
| /** | |||
| * This validator validates according to Java 21 syntax rules. | |||
| * This validator validates according to Java 23 syntax rules. | |||
| * | |||
| * @see <a href="https://openjdk.java.net/projects/jdk/21/">https://openjdk.java.net/projects/jdk/21/</a> | |||
martinaldrin
suggested changes
Jun 2, 2025
| @@ -20,7 +20,7 @@ | |||
| package com.github.javaparser.ast.validator.language_level_validations; | |||
|
|
|||
| /** | |||
| * This validator validates according to Java 21 syntax rules. | |||
| * This validator validates according to Java 22 syntax rules. | |||
| * | |||
| * @see <a href="https://openjdk.java.net/projects/jdk/21/">https://openjdk.java.net/projects/jdk/21/</a> | |||
| @@ -20,7 +20,7 @@ | |||
| package com.github.javaparser.ast.validator.language_level_validations; | |||
|
|
|||
| /** | |||
| * This validator validates according to Java 21 syntax rules. | |||
| * This validator validates according to Java 23 syntax rules. | |||
| * | |||
| * @see <a href="https://openjdk.java.net/projects/jdk/21/">https://openjdk.java.net/projects/jdk/21/</a> | |||
martinaldrin
reviewed
Jun 2, 2025
| /** | ||
| * Java 24 | ||
| */ | ||
| JAVA_24(new Java24Validator(), new Java24PostProcessor()); |
There was a problem hiding this comment.
could we prepare for JAVA_25 directly?
| /** | ||
| * Java 24 | ||
| */ | ||
| JAVA_24(new Java24Validator(), new Java24PostProcessor()); | ||
|
|
||
| /** | ||
| * Does no post processing or validation. Only for people wanting the fastest parsing. |
There was a problem hiding this comment.
maybe also time to update
public static LanguageLevel POPULAR = JAVA_11; -> 17?
public static LanguageLevel CURRENT = JAVA_18; -> 21=
public static LanguageLevel BLEEDING_EDGE = JAVA_21; -> 24?
|
Thank you for this proposition, but this PR will not be merged in this state because JP does not support all the features of the various java versions. If this PR had been subdivided into several PRs (one per version of java) they would have been easier to integrate as soon as the different features specific to each version had been developed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4699