Skip to content

bugfix for issue#1033 #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skyshore2001
Copy link
Contributor

bugfix: for array with table format and option remove_empty_properties=true, moving item with empty property does not work.
issue#1033: Data are copying instead of move when using navigation button and remove_empty_properties = true

Q A
Is bugfix? ✔️
New feature?
Is backward-compatible? ✔️
Tests pass? N.A.
Fixed issues #1033
Updated README/docs?
Added CHANGELOG entry?

@schmunk42
Copy link
Collaborator

@skyshore2001 Could you update your branch, we've fixed some build issues on master.

…s=true, moving item with empty property does not work.

issue#1033: Data are copying instead of move when using navigation button and remove_empty_properties = true
@skyshore2001
Copy link
Contributor Author

updated

@skyshore2001
Copy link
Contributor Author

I checked the failed case but it seems correct when I open the page, click button and check the result manually:
$('[data-schemapath="root.integer_range"] output').innerHTML is 2 as expected.
I need help how to debug the case.

@schmunk42
Copy link
Collaborator

I checked the failed case but it seems correct when I open the page, click button and check the result manually: $('[data-schemapath="root.integer_range"] output').innerHTML is 2 as expected. I need help how to debug the case.

Tests are passing now, they just have hickups from time to time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants