-
Notifications
You must be signed in to change notification settings - Fork 697
Don't run uniqueItems validator if set to false #1626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@StevenGranados Could you raise this value to 161 in your branch, since you added 3 assertions. I do not know why unit tests are failing atm. CC: @germanbisurgi |
@schmunk42 done |
@germanbisurgi Could you have a look at the failing unit-tests. |
Hi, is there any chance of revisiting this one? |
@StevenGranados Hi, i tested your branch here: https://github.com/json-editor/json-editor/actions/runs/14835082261/job/41644950166 the error in the unit test is caused by the missing property “invalid” in the fixtures file. The property must be set and be an array, as the tester runs through it without checking whether it is set or not. Add this property and push it again and the test will be green again 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing "invalid" property in fixture braks unit tests.
} | ||
] | ||
] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the property "invalid" (Array)
I've added the property. The tests in PR #1663 fail for firefox, but I don't know why |
Was a slow CI problem. now are green |
@germanbisurgi Can we merge this now? |
yes |
Uh oh!
There was an error while loading. Please reload this page.