Skip to content

Don't run uniqueItems validator if set to false #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

StevenGranados
Copy link

@StevenGranados StevenGranados commented Oct 28, 2024

Q A
Is bugfix? ✔️
New feature?
Is backward-compatible? ✔️
Tests pass? ✔️
Fixed issues #1625
Updated README/docs?
Added CHANGELOG entry? ✔️

@schmunk42
Copy link
Collaborator

@StevenGranados Could you raise this value to 161 in your branch, since you added 3 assertions.

I do not know why unit tests are failing atm. CC: @germanbisurgi

@StevenGranados
Copy link
Author

@schmunk42 done

@schmunk42
Copy link
Collaborator

@germanbisurgi Could you have a look at the failing unit-tests.

@StevenGranados
Copy link
Author

Hi, is there any chance of revisiting this one?

@schmunk42 schmunk42 requested a review from germanbisurgi April 29, 2025 15:39
@germanbisurgi
Copy link
Collaborator

@StevenGranados Hi, i tested your branch here:

https://github.com/json-editor/json-editor/actions/runs/14835082261/job/41644950166

the error in the unit test is caused by the missing property “invalid” in the fixtures file.

The property must be set and be an array, as the tester runs through it without checking whether it is set or not.

Add this property and push it again and the test will be green again 🙂

Copy link
Collaborator

@germanbisurgi germanbisurgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing "invalid" property in fixture braks unit tests.

}
]
]
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the property "invalid" (Array)

@StevenGranados
Copy link
Author

I've added the property. The tests in PR #1663 fail for firefox, but I don't know why

@germanbisurgi
Copy link
Collaborator

Was a slow CI problem. now are green

@schmunk42
Copy link
Collaborator

@germanbisurgi Can we merge this now?

@germanbisurgi
Copy link
Collaborator

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants