Inherit @TestMethodOrder and introduce Default orderer implementations
#4842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use a cache for the `DescriptorWrapperOrderer` in both cases * Include test class in warning messages in both cases
ec1f1d7 to
365bfa0
Compare
sormuras
approved these changes
Aug 19, 2025
sbrannen
requested changes
Aug 19, 2025
There was a problem hiding this comment.
Thanks for working on this!
It looks very good.
Although I reviewed the entire PR, I did not spend a lot of time reviewing the interim refactoring commit. Thus, I assume the refactoring part is "good to go" as well.
Otherwise, I've only requested a few minor changes to Javadoc and tests.
junit-jupiter-api/src/main/java/org/junit/jupiter/api/ClassOrderer.java
Outdated
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/MethodOrderer.java
Outdated
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/ClassOrderer.java
Outdated
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/MethodOrderer.java
Outdated
Show resolved
Hide resolved
jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/OrderedClassTests.java
Show resolved
Hide resolved
jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/OrderedMethodTests.java
Outdated
Show resolved
Hide resolved
jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/OrderedMethodTests.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sam Brannen <104798+sbrannen@users.noreply.github.com>
sbrannen
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TestMethodOrderto enclosed@NestedclassesMethodOrderer.Defaultfor reverting back to default orderingClassOrderer.Defaultfor reverting back to default orderingResolves #4731.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations