Introduce selectClasses*() variants in DiscoverySelectors
#4863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, it was possible to select multiple classes by
invoking selectClass(<class>) multiple times; however, it could become
a bit verbose as in the following example.
EngineTestKit.engine("junit-jupiter")
.selectors(
selectClass(TestClass1A.class),
selectClass(TestClass1B.class),
selectClass(TestClass2A.class),
selectClass(TestClass2B.class))
To improve the programming model for users, this commit introduces
multiple selectClasses(...) and selectClassesByName(...) variants in
DiscoverySelectors. The following examples demonstrates use of the new
selectClasses(Class<?>...) varargs variant.
EngineTestKit.engine("junit-jupiter")
.selectors(
selectClasses(
TestClass1A.class,
TestClass1B.class,
TestClass2A.class,
TestClass2B.class))
In addition, the AdditionalDiscoverySelectors utility used by the
@Suite engine no longer needs to implement its own selectClasses(...)
utilities.
Closes junit-teamgh-4860
324a187 to
dbad78a
Compare
sormuras
approved these changes
Aug 22, 2025
dbad78a to
bb48ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, it was possible to select multiple classes by invoking
selectClass(<class>)multiple times; however, it could become a bit verbose as in the following example.To improve the programming model for users, this commit introduces multiple
selectClasses(...)andselectClassesByName(...)variants inDiscoverySelectors. The following example demonstrates use of the newselectClasses(Class<?>...)varargs variant.In addition, the
AdditionalDiscoverySelectorsutility used by the@Suiteengine no longer needs to implement its ownselectClasses(...)utilities.Closes gh-4860