Skip to content

Adds ability to pass object with mode value to shadow prop #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds ability to pass object with mode value to shadow prop #146

wants to merge 1 commit into from

Conversation

inigay
Copy link

@inigay inigay commented Sep 13, 2018

No description provided.

@inigay
Copy link
Author

inigay commented Sep 13, 2018

Take a look at the change. The object or boolean-ish values work. Although it's still not rendering shadowRoot elements when closed is used

@karol-f
Copy link
Owner

karol-f commented Sep 13, 2018 •
edited
Loading

@inigay Ach, I see. This is due to our use of shadowRoot, which is unavailable in closed mode - https://blog.revillweb.com/open-vs-closed-shadow-dom-9f3d7427d1af#f82a

We have to manually keep shadowRoot reference and change line with it's occurrence, e.g.:

vue-custom-element/src/utils/createVueInstance.js

Line 87 in 373d59f

rootElement.el = element.shadowRoot.children[0];

Regards!

@karol-f
Copy link
Owner

karol-f commented Oct 5, 2018

Hi, can is it possible to update the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting for feedback from issue author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inigay @karol-f