バグ修正(format predictionの1d_flagのインデックス, dotsの除去が正常にできていない) #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## stable #258 +/- ##
==========================================
+ Coverage 90.52% 90.58% +0.06%
==========================================
Files 64 64
Lines 2764 2847 +83
==========================================
+ Hits 2502 2579 +77
- Misses 262 268 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
標記の通り、format predictionの1d_flagのインデックスがfirst_indexでなくてsecond_indexを取っているバグとdotsの除去ができていない(くっついてしまって変数と認識されないことがある)ところを修正しました。
これによって、1d_flagが正常に動いていなかったものが動くようになり新たに50個ほどのpredictionが成功するようになりました。
一方で面白いことにこのバグによって読めてしまっていた5つほどが失敗するようになりました。原因は二次元配列が転置していて、従来のsecond_indexをとるとうまくいってしまうもの、または1次元の文字列を読む(c_0c_1...c_N)といったものです。
詳しくはtests/resources/test_fmtprediction/answer.txtをご覧ください。