perf: optimize loop performance by pre-calculating array counts in Str::apa() and fileSize() methods (#56796)

AmadulHaque · taylorotwell · web-flow · commit b51cb931c62f · 2025-08-27T13:46:27.000-05:00
* Refactor: Pre-calculate array counts before loops

This commit optimizes loops within the `Str::apa` and `Number::fileSize` methods by pre-calculating the array count and storing it in a variable.

Previously, the `count()` function was called on each iteration, leading to minor performance overhead. This change avoids these redundant function calls.

* This commit   perform static analysis and improve overall code quality.

As an initial application of the tool, the `Number::fileSize` method has been refactored for performance. The array count is now cached in a variable before the loop to avoid calling `count()` on every iteration.

* Formatting

---------

Co-authored-by: Taylor Otwell &lt;taylor@laravel.com&gt;
diff --git a/src/Illuminate/Support/Number.php b/src/Illuminate/Support/Number.php
@@ -207,7 +207,9 @@ public static function fileSize(int|float $bytes, int $precision = 0, ?int $maxP
     {
         $units = ['B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'];
 
-        for ($i = 0; ($bytes / 1024) > 0.9 && ($i < count($units) - 1); $i++) {
+        $unitCount = count($units);
+
+        for ($i = 0; ($bytes / 1024) > 0.9 && ($i < $unitCount - 1); $i++) {
             $bytes /= 1024;
         }
 
diff --git a/src/Illuminate/Support/Str.php b/src/Illuminate/Support/Str.php
@@ -1458,8 +1458,9 @@ public static function apa($value)
         $endPunctuation = ['.', '!', '?', ':', '—', ','];
 
         $words = mb_split('\s+', $value);
+        $wordCount = count($words);
 
-        for ($i = 0; $i < count($words); $i++) {
+        for ($i = 0; $i < $wordCount; $i++) {
             $lowercaseWord = mb_strtolower($words[$i]);
 
             if (str_contains($lowercaseWord, '-')) {

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,9 @@ public static function fileSize(int\|float $bytes, int $precision = 0, ?int $maxP`
`207`	`207`	`{`
`208`	`208`	`$units = ['B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'];`
`209`	`209`
`210`		`- for ($i = 0; ($bytes / 1024) > 0.9 && ($i < count($units) - 1); $i++) {`
	`210`	`+ $unitCount = count($units);`
	`211`	`+`
	`212`	`+ for ($i = 0; ($bytes / 1024) > 0.9 && ($i < $unitCount - 1); $i++) {`
`211`	`213`	`$bytes /= 1024;`
`212`	`214`	`}`
`213`	`215`