perf: optimize loop performance by pre-calculating array counts in Str::apa() and fileSize() methods #56796
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit optimizes loops within the `Str::apa` and `Number::fileSize` methods by pre-calculating the array count and storing it in a variable. Previously, the `count()` function was called on each iteration, leading to minor performance overhead. This change avoids these redundant function calls.
As an initial application of the tool, the `Number::fileSize` method has been refactored for performance. The array count is now cached in a variable before the loop to avoid calling `count()` on every iteration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request optimizes two string utility functions by avoiding repeated
count()function calls within loop conditions. The changes improve performance by pre-calculating array counts before entering loops, eliminating unnecessary function calls during each iteration.Changes Made
1.
Str::apa()Methodcount($words)called on every loop iteration$wordCountvariable for a single calculation2.
fileSize()Methodcount($units)called on every loop iteration$unitsCountvariable for a single calculationPerformance Impact
These optimizations provide measurable performance benefits, especially when processing:
apa()methodfileSize()methodThe changes maintain identical functionality while reducing computational overhead.
Code Quality
Testing
All existing tests continue to pass, confirming that the functionality remains unchanged while performance is enhanced.