[12.x] Prefer Symfony PHP polyfills over function_exists
calls
#56621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In various places of the codebase,
function_exists
calls are employed to allow usage of functions introduced in recent PHP versions without breaking backwards compatibility. This has two major downsides namely:Therefore this PR proposes to use the Symfony polyfills instead. This will ensure the functions are available on all supported PHP versions, thus retaining backwards compatibility, without requiring any code modifications. Moreover, given these are easily findable in the corresponding
composer.json
files, they can be easily removed in the future when the PHP version is raised, without further checking which functions correspond to which PHP version.