[12.x] Test Improvements #56635
Merged
[12.x] Test Improvements #56635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#56216) * Formatting * Add breaking test to demo config array has been incorrectly keyed with numbers * Correct how base options for missing config files are preloaded
The Symfony Command uses the AsCommand attribute to set properties on the command class. However, the properties are only set if they are identical to an empty string. The Laravel Command class overrides the properties and removes the default value which causes the properties to be null and therefore not set.
- Fix integration with PHPUnit 12.3.4 - Fix PHPStan Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
…/tests-improvements
…/tests-improvements Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
crynobone
commented
Aug 12, 2025
| @@ -113,7 +113,7 @@ | |||
| "league/flysystem-read-only": "^3.25.1", | |||
| "league/flysystem-sftp-v3": "^3.25.1", | |||
| "mockery/mockery": "^1.6.10", | |||
| "orchestra/testbench-core": "^10.0.0", | |||
| "orchestra/testbench-core": "10.x-dev#57a17219", | |||
There was a problem hiding this comment.
Will update this once this has been merged.
crynobone
commented
Aug 12, 2025
| @@ -45,7 +45,7 @@ class Application extends Container implements ApplicationContract, CachesConfig | |||
| * | |||
| * @var string | |||
| */ | |||
| const VERSION = '12.23.1'; | |||
| const VERSION = '12.23.2'; | |||
There was a problem hiding this comment.
This just to make sure Testbench logic works correctly:
LauJosefsen
referenced
this pull request
in sebastianbergmann/phpunit
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply #56630 fixes