[12.x] Add allowedUrls
through preventStrayRequests
#56645
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose behind
Http::preventStrayRequests()
is great - it stops any stray requests from hitting endpoints.However, this also means that if you’re trying to use SSR to check the output from something like Inertia, those requests will be blocked and a
StrayRequestException
will be thrown.This PR expands the existing
Http::allowStrayRequests()
method to accept an array of “allowed” URLs.For example:
To keep things fully backward-compatible, calling
allowStrayRequests()
without arguments still turnspreventStrayRequests
off entirely, as it did before.Both the
Http\Client\Factory
andHttp\Client\PendingResponse
classes have been adjusted to accept and pass the allowed list of URLs.I’ve added a simple test to ensure the allow-list logic works.
I avoided adding a test that actually hits a real endpoint, since depending on when/how the tests are run, the result could vary - even for
127.0.0.1
.