Skip to content

[12.x] Code formatting #56658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

AhmedAlaa4611
Copy link
Contributor

Description

Fix indentation.

@rodrigopedra
Copy link
Contributor

It looks to me that the current code follows Laravel's formatting already.

Also, I am pretty sure the StyleCI pipeline takes care of fixing any out-of-place styles.

Of course, any automated tools may fail on edge cases. But it is very unlikely that indentation on chained method calls would be one of these cases.

@shaedrich
Copy link
Contributor

Besides, the indention is opinionated. It's quite common to indent the first method after the first line break, meaning, even if the first method is not indented because it's on the same like as the start of the statement, the next methods will.

@browner12
Copy link
Contributor

yah, this goes against a lot of the formatting changes I've made over the past couple of years to get more standardization in chained method calls. Ideally what we'd do here is put the ->all() call on its own line for better readability and better diffs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants