Skip to content

[12.x] Remove @throws phpDocs in the TransformToResource trait #56667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025

Conversation

adelf
Copy link
Contributor

@adelf adelf commented Aug 15, 2025

The trait methods throw only LogicException, which should never be in the "catch()" section.

PhpDoc in LogicException:
Exception that represents error in the program logic. This kind of exception should lead directly to a fix in your code.

So, these methods shouldn't contain any @throws phpDoc

@taylorotwell taylorotwell merged commit bbc66da into laravel:12.x Aug 15, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants