[13.x] Make QueueBusy event consistent with other queue events #56673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the failing tests will be resolved once 12.x is merged into 13.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
QueueBusyevent, the$connectionproperty currently holds the connection name. However, all other queue events likeJobProcessed,JobFailed, etc. use$connectionNamefor this property.This PR updates
QueueBusyto use$connectionNamefor consistency with the rest of the queue events and to avoid confusion that$connectionmight be an actual connection instance.Since this is a breaking change, it is being reintroduced for the next release where breaking changes are acceptable.