Skip to content

[12.x] Simpler and consistent Arr::collapse() #56842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2025
Merged

[12.x] Simpler and consistent Arr::collapse() #56842

merged 2 commits into from
Aug 31, 2025

Conversation

weshooper
Copy link
Contributor

@weshooper weshooper commented Aug 31, 2025 •
edited
Loading

Removed the negation and continue as felt easier to read, plus removed reuse of $values variable in the loop.

@weshooper
Simpler and consistent Arr::collapse()
4a316b9 
Removed the negation and `continue` as felt easier to read, consistent with other methods here.
@weshooper weshooper changed the title Simpler and consistent Arr::collapse() [12.x] Simpler and consistent Arr::collapse() Aug 31, 2025
@taylorotwell taylorotwell merged commit fca7209 into laravel:12.x Aug 31, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weshooper @taylorotwell