[12.x] Fix docblocks and all() method in ArrayStore for consistency #56845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an inconsistency between the ArrayStore docblocks and its actual runtime behavior.
Currently, the PHPDoc annotations and the
all()method suggest that cached items are stored as:However, the
put()method actually stores items as:This PR updates the docblocks and the
all()method to reflect the correct array shape.No behavior is changed; only the documentation and array construction order are corrected for consistency.
See
framework/src/Illuminate/Cache/ArrayStore.php
Lines 101 to 109 in a7917a7