[12.x] Improve countBy docblock in Collection to allow for enum callback
#56856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's completely fine and not a breaking change to update the Enumerable doc block In cases like that, the template should be left as the callable return and you can do some sort of conditional return depending on what the template type is. However, backed enums aren't generic, so not really possible to tell if it's an int or string. This may just have to be handled in a Larastan extension |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #56830 this PR ensures the docblock of the
Collectionclass is adequately updated as well.Notes:
Enumerableinterface docblock here, given that updating its signature (even though only 'softly' in a docblock) should probably be considered a breaking change. I'm willing to follow-up with doing this while targetting themasterbranch.groupBydocblock, which includescallable(TValue, TKey): TGroupKeybut probably should be changed to saycallable(TValue, TKey): TGroupKey|\BackedEnum|\Stringablegiven the implementation. However, when trying such things I quickly ran into errors of the sortso maybe this requires some additional care.