Skip to content

[12.x] Remove extra space before line number in exception trace #56863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2025
Merged

[12.x] Remove extra space before line number in exception trace #56863

merged 2 commits into from
Sep 1, 2025

Conversation

mtbossa
Copy link
Contributor

@mtbossa mtbossa commented Sep 1, 2025 •
edited
Loading

This pull request improves the exception renderer UI by refining how file and line references are displayed.

  • The file name and line number are now rendered together as part of the clickable link (or plain text). This ensures that when copying the reference, IDEs like PhpStorm can correctly open the file at the specified line. Previously, an extra space prevented this behavior.
  • The link color was being overridden by an inner <span> style, making it appear as plain text. This has been corrected so clickable links are visually distinct.

Example

Before

Copied text:

routes/web.php :7
Screenshot before

After

Copied text:

routes/web.php:7
Screenshot after

@mtbossa mtbossa marked this pull request as draft September 1, 2025 18:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2025

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@mtbossa mtbossa marked this pull request as ready for review September 1, 2025 18:58
@taylorotwell taylorotwell merged commit 1e7df51 into laravel:12.x Sep 1, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtbossa @taylorotwell