feat: add filenameHashing option (vuejs#1980)

yhvicey · yyx990803 · commit ce7b39456031 · 2018-07-30T15:30:30.000-04:00
diff --git a/packages/@vue/cli-service/lib/Service.js b/packages/@vue/cli-service/lib/Service.js
@@ -297,7 +297,7 @@ module.exports = class Service {
       resovledFrom = 'inline options'
     }
 
-    // normlaize some options
+    // normalize some options
     if (typeof resolved.baseUrl === 'string') {
       resolved.baseUrl = resolved.baseUrl.replace(/^\.\//, '')
     }
diff --git a/packages/@vue/cli-service/lib/config/base.js b/packages/@vue/cli-service/lib/config/base.js
@@ -82,7 +82,10 @@ module.exports = (api, options) => {
           .loader('url-loader')
           .options({
             limit: inlineLimit,
-            name: getAssetPath(options, `img/[name].[hash:8].[ext]`)
+            name: getAssetPath(
+              options,
+              `img/[name]${options.filenameHashing ? '.[hash:8]' : ''}.[ext]`
+            )
           })
 
     // do not base64-inline SVGs.
@@ -93,7 +96,10 @@ module.exports = (api, options) => {
         .use('file-loader')
           .loader('file-loader')
           .options({
-            name: getAssetPath(options, `img/[name].[hash:8].[ext]`)
+            name: getAssetPath(
+              options,
+              `img/[name]${options.filenameHashing ? '.[hash:8]' : ''}.[ext]`
+            )
           })
 
     webpackConfig.module
@@ -103,7 +109,10 @@ module.exports = (api, options) => {
           .loader('url-loader')
           .options({
             limit: inlineLimit,
-            name: getAssetPath(options, `media/[name].[hash:8].[ext]`)
+            name: getAssetPath(
+              options,
+              `media/[name]${options.filenameHashing ? '.[hash:8]' : ''}.[ext]`
+            )
           })
 
     webpackConfig.module
@@ -113,7 +122,10 @@ module.exports = (api, options) => {
           .loader('url-loader')
           .options({
             limit: inlineLimit,
-            name: getAssetPath(options, `fonts/[name].[hash:8].[ext]`)
+            name: getAssetPath(
+              options,
+              `fonts/[name]${options.filenameHashing ? '.[hash:8]' : ''}.[ext]`
+            )
           })
 
     // Other common pre-processors ---------------------------------------------
diff --git a/packages/@vue/cli-service/lib/config/css.js b/packages/@vue/cli-service/lib/config/css.js
@@ -25,7 +25,7 @@ module.exports = (api, options) => {
     const shouldExtract = isProd && extract !== false && !shadowMode
     const filename = getAssetPath(
       options,
-      `css/[name].[contenthash:8].css`,
+      `css/[name]${options.filenameHashing ? '.[contenthash:8]' : ''}.css`,
       true /* placeAtRootIfRelative */
     )
     const extractOptions = Object.assign({
diff --git a/packages/@vue/cli-service/lib/config/prod.js b/packages/@vue/cli-service/lib/config/prod.js
@@ -5,7 +5,7 @@ module.exports = (api, options) => {
       const getAssetPath = require('../util/getAssetPath')
       const filename = getAssetPath(
         options,
-        `js/[name]${isLegacyBundle ? `-legacy` : ``}.[chunkhash:8].js`
+        `js/[name]${isLegacyBundle ? `-legacy` : ``}${options.filenameHashing ? '.[chunkhash:8]' : ''}.js`
       )
 
       webpackConfig
diff --git a/packages/@vue/cli-service/lib/options.js b/packages/@vue/cli-service/lib/options.js
@@ -3,6 +3,7 @@ const { createSchema, validate } = require('@vue/cli-shared-utils')
 const schema = createSchema(joi => joi.object({
   baseUrl: joi.string().allow(''),
   outputDir: joi.string(),
+  filenameHashing: joi.boolean(),
   assetsDir: joi.string(),
   indexPath: joi.string(),
   runtimeCompiler: joi.boolean(),
@@ -53,6 +54,9 @@ exports.defaults = () => ({
   // where to output built files
   outputDir: 'dist',
 
+  // whether filename will contain hash part
+  filenameHashing: true,
+
   // where to put static assets (js/css/img/font/...)
   assetsDir: '',
 

Original file line number	Diff line number	Diff line change
`@@ -297,7 +297,7 @@ module.exports = class Service {`
`297`	`297`	`resovledFrom = 'inline options'`
`298`	`298`	`}`
`299`	`299`
`300`		`- // normlaize some options`
	`300`	`+ // normalize some options`
`301`	`301`	`if (typeof resolved.baseUrl === 'string') {`
`302`	`302`	`resolved.baseUrl = resolved.baseUrl.replace(/^\.\//, '')`
`303`	`303`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ module.exports = (api, options) => {`
`25`	`25`	`const shouldExtract = isProd && extract !== false && !shadowMode`
`26`	`26`	`const filename = getAssetPath(`
`27`	`27`	`options,`
`28`		- `css/[name].[contenthash:8].css`,
	`28`	+ `css/[name]${options.filenameHashing ? '.[contenthash:8]' : ''}.css`,
`29`	`29`	`true /* placeAtRootIfRelative */`
`30`	`30`	`)`
`31`	`31`	`const extractOptions = Object.assign({`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ module.exports = (api, options) => {`
`5`	`5`	`const getAssetPath = require('../util/getAssetPath')`
`6`	`6`	`const filename = getAssetPath(`
`7`	`7`	`options,`
`8`		- `js/[name]${isLegacyBundle ? `-legacy` : ``}.[chunkhash:8].js`
	`8`	+ `js/[name]${isLegacyBundle ? `-legacy` : ``}${options.filenameHashing ? '.[chunkhash:8]' : ''}.js`
`9`	`9`	`)`
`10`	`10`
`11`	`11`	`webpackConfig`