TW-818: fix: prevent inlineSpanEnd from getting main span styles #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f231347 to
f800cd6
Compare
|
where can you find that ? |
|
upstream repository: https://github.com/Sorunome/flutter_matrix_html |
f800cd6 to
bf52d9e
Compare
|
discussed with @drminh2807 there is no problem with my solution, he was asking for resources. Added upstream PR to soru's repo |
drminh2807
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InlineSpanEnd was getting styles from the codeblock, now parsed spans and inline span are separated
upstream here Sorunome#12