Remove unused config from secretsManagerClient

allisaurus · allisaurus · commit b01a69c0c659 · 2018-08-08T16:16:23.000-07:00
diff --git a/ecs-cli/modules/clients/aws/secretsmanager/client.go b/ecs-cli/modules/clients/aws/secretsmanager/client.go
@@ -28,21 +28,19 @@ type SMClient interface {
 
 type secretsManagerClient struct {
 	client secretsmanageriface.SecretsManagerAPI
-	config *config.CommandConfig
 }
 
 // NewSecretsManagerClient creates an instance of an secretsManagerClient
 func NewSecretsManagerClient(config *config.CommandConfig) SMClient {
 	client := secretsmanager.New(config.Session)
 	client.Handlers.Build.PushBackNamed(clients.CustomUserAgentHandler())
 
-	return newClient(config, client)
+	return newClient(client)
 }
 
-func newClient(config *config.CommandConfig, client secretsmanageriface.SecretsManagerAPI) SMClient {
+func newClient(client secretsmanageriface.SecretsManagerAPI) SMClient {
 	return &secretsManagerClient{
 		client: client,
-		config: config,
 	}
 }
 
diff --git a/ecs-cli/modules/clients/aws/secretsmanager/client_test.go b/ecs-cli/modules/clients/aws/secretsmanager/client_test.go
@@ -18,9 +18,7 @@ import (
 	"testing"
 
 	"github.com/aws/amazon-ecs-cli/ecs-cli/modules/clients/aws/secretsmanager/mock/sdk"
-	"github.com/aws/amazon-ecs-cli/ecs-cli/modules/config"
 	"github.com/aws/aws-sdk-go/aws"
-	"github.com/aws/aws-sdk-go/aws/session"
 	"github.com/aws/aws-sdk-go/service/secretsmanager"
 	"github.com/golang/mock/gomock"
 	"github.com/stretchr/testify/assert"
@@ -97,10 +95,7 @@ func TestListSecretsErrorCase(t *testing.T) {
 func setupTestController(t *testing.T) (*mock_secretsmanageriface.MockSecretsManagerAPI, SMClient) {
 	ctrl := gomock.NewController(t)
 	mockSM := mock_secretsmanageriface.NewMockSecretsManagerAPI(ctrl)
-	mockSession, err := session.NewSession()
-	assert.NoError(t, err, "Unexpected error in creating session")
-
-	client := newClient(&config.CommandConfig{Session: mockSession}, mockSM)
+	client := newClient(mockSM)
 
 	return mockSM, client
 }

Original file line number	Diff line number	Diff line change
`@@ -28,21 +28,19 @@ type SMClient interface {`
`28`	`28`
`29`	`29`	`type secretsManagerClient struct {`
`30`	`30`	`client secretsmanageriface.SecretsManagerAPI`
`31`		`- config *config.CommandConfig`
`32`	`31`	`}`
`33`	`32`
`34`	`33`	`// NewSecretsManagerClient creates an instance of an secretsManagerClient`
`35`	`34`	`func NewSecretsManagerClient(config *config.CommandConfig) SMClient {`
`36`	`35`	`client := secretsmanager.New(config.Session)`
`37`	`36`	`client.Handlers.Build.PushBackNamed(clients.CustomUserAgentHandler())`
`38`	`37`
`39`		`- return newClient(config, client)`
	`38`	`+ return newClient(client)`
`40`	`39`	`}`
`41`	`40`
`42`		`-func newClient(config *config.CommandConfig, client secretsmanageriface.SecretsManagerAPI) SMClient {`
	`41`	`+func newClient(client secretsmanageriface.SecretsManagerAPI) SMClient {`
`43`	`42`	`return &secretsManagerClient{`
`44`	`43`	`client: client,`
`45`		`- config: config,`
`46`	`44`	`}`
`47`	`45`	`}`
`48`	`46`