[llvm][CI] Add metrics collection for libc++ premerge testing. #152801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
** DRAFT!! DO NOT REVIEW! DO NOT MERGE! ** Work-in-progress, playing around with adding metrics collection and dashboard for libc++ premerge testing data.
Finish updating metrics.py to collect libc++ testing metrics.
|
✅ With the latest revision this PR passed the Python code formatter. |
Fix two tiny bugs in metrics.py
|
I've added tests for all the libc++ work now. This should be ready to review again. |
There was a problem hiding this comment.
The formatter still needs to be fixed. https://llvm.org/docs/CodingStandards.html#python-version-and-source-code-formatting has information on what to do in case you aren't already familiar.
Other than that, a couple nits and I think this is ready to go.
boomanaiden154
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the metrics.py script to collect mertrics on libc++ premerge testing (on linux); also to create aggregate summaries for the three stages; and to upload the libc++ metrics data to Grafana.