[mlir][debug] Convert DbgIntrOp to DebugRecords directly. #154926
Conversation
Currently the DbgIntrOp are first converted to llvm intrinsics which are laterr translated to debug records by a call of convertToNewDbgValues. This is not only inefficient but also makes the code that works on intermediate IR unnecessarily complicated. This PR converts the DbgIntrOp directly to debug records. The conversion is relatively simple but there is a bit of code repetition due to how the APIs in the DIBuilders are named. Also noticed that DISubprogramAttr is inherited from DIScopeAttr while in llvm, the DISubprogram inherits from DILocalScope. I am going to fix this separately and then we could use FusedLocWith<LLVM::DILocalScopeAttr> and cast to <DILocalScope> will be much safer.
|
@llvm/pr-subscribers-mlir Author: Abid Qadeer (abidh) ChangesCurrently the The conversion is relatively simple but there is a bit of code repetition due to how the APIs in the As the output remains the same, the existing tests cover this change. I also ran the Full diff: https://github.com/llvm/llvm-project/pull/154926.diff 3 Files Affected:
diff --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
index 5e2461b4508e4..f964eb079a725 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
+++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
@@ -673,22 +673,6 @@ def LLVM_CoroPromiseOp : LLVM_IntrOp<"coro.promise", [], [], [], 1> {
class LLVM_DbgIntrOp<string name, string argName, list<Trait> traits = []>
: LLVM_IntrOp<name, [], [], traits, 0> {
- let llvmBuilder = [{
- // Debug intrinsics without debug locations are invalid.
- if(!builder.getCurrentDebugLocation())
- return success();
- llvm::Module *module = builder.GetInsertBlock()->getModule();
- llvm::LLVMContext &ctx = module->getContext();
- llvm::Function *fn =
- llvm::Intrinsic::getOrInsertDeclaration(module, llvm::Intrinsic::}]
- # !subst(".", "_", name) # [{);
- builder.CreateCall(fn, {
- llvm::MetadataAsValue::get(ctx,
- llvm::ValueAsMetadata::get(moduleTranslation.lookupValue(opInst.getOperand(0)))),
- llvm::MetadataAsValue::get(ctx, moduleTranslation.translateDebugInfo($varInfo)),
- llvm::MetadataAsValue::get(ctx, moduleTranslation.translateExpression($locationExpr)),
- });
- }];
let mlirBuilder = [{
// Add debug intrindic to the list of intrinsics that need to be converted once the
// full function was converted.
@@ -711,6 +695,28 @@ def LLVM_DbgDeclareOp : LLVM_DbgIntrOp<"dbg.declare", "addr", [
LLVM_DILocalVariableAttr:$varInfo,
DefaultValuedAttr<LLVM_DIExpressionAttr, "{}">:$locationExpr
);
+ let llvmBuilder = [{
+ // Debug intrinsics without debug locations are invalid.
+ if(!builder.getCurrentDebugLocation())
+ return success();
+ llvm::Function *parentFn = builder.GetInsertBlock()->getParent();
+ llvm::DILocalScope *scope;
+ if (auto scopeLoc =
+ opInst.getLoc()->findInstanceOf<FusedLocWith<LLVM::DIScopeAttr>>())
+ scope = llvm::cast<llvm::DILocalScope>(
+ moduleTranslation.translateDebugInfo(scopeLoc.getMetadata()));
+ else
+ scope = parentFn->getSubprogram();
+
+ llvm::Module *module = builder.GetInsertBlock()->getModule();
+ llvm::DIBuilder DB(*module);
+ DB.insertDeclare(moduleTranslation.lookupValue(opInst.getOperand(0)),
+ llvm::cast<llvm::DILocalVariable>(
+ moduleTranslation.translateDebugInfo($varInfo)),
+ moduleTranslation.translateExpression($locationExpr),
+ moduleTranslation.translateLoc(opInst.getLoc(), scope),
+ builder.GetInsertPoint());
+ }];
}
def LLVM_DbgValueOp : LLVM_DbgIntrOp<"dbg.value", "value",
@@ -721,6 +727,29 @@ def LLVM_DbgValueOp : LLVM_DbgIntrOp<"dbg.value", "value",
LLVM_DILocalVariableAttr:$varInfo,
DefaultValuedAttr<LLVM_DIExpressionAttr, "{}">:$locationExpr
);
+ let llvmBuilder = [{
+ // Debug intrinsics without debug locations are invalid.
+ if(!builder.getCurrentDebugLocation())
+ return success();
+ llvm::Function *parentFn = builder.GetInsertBlock()->getParent();
+ llvm::DILocalScope *scope;
+ if (auto scopeLoc =
+ opInst.getLoc()->findInstanceOf<FusedLocWith<LLVM::DIScopeAttr>>())
+ scope = llvm::cast<llvm::DILocalScope>(
+ moduleTranslation.translateDebugInfo(scopeLoc.getMetadata()));
+ else
+ scope = parentFn->getSubprogram();
+
+ llvm::Module *module = builder.GetInsertBlock()->getModule();
+ llvm::DIBuilder DB(*module);
+ DB.insertDbgValueIntrinsic(
+ moduleTranslation.lookupValue(opInst.getOperand(0)),
+ llvm::cast<llvm::DILocalVariable>(
+ moduleTranslation.translateDebugInfo($varInfo)),
+ moduleTranslation.translateExpression($locationExpr),
+ moduleTranslation.translateLoc(opInst.getLoc(), scope),
+ builder.GetInsertPoint());
+ }];
}
def LLVM_DbgLabelOp : LLVM_IntrOp<"dbg.label", [], [], [], 0> {
@@ -730,13 +759,21 @@ def LLVM_DbgLabelOp : LLVM_IntrOp<"dbg.label", [], [], [], 0> {
// Debug intrinsics without debug locations are invalid.
if(!builder.getCurrentDebugLocation())
return success();
+ llvm::Function *parentFn = builder.GetInsertBlock()->getParent();
+ llvm::DILocalScope *scope;
+ if (auto scopeLoc =
+ opInst.getLoc()->findInstanceOf<FusedLocWith<LLVM::DIScopeAttr>>())
+ scope = llvm::cast<llvm::DILocalScope>(
+ moduleTranslation.translateDebugInfo(scopeLoc.getMetadata()));
+ else
+ scope = parentFn->getSubprogram();
+
llvm::Module *module = builder.GetInsertBlock()->getModule();
- llvm::LLVMContext &ctx = module->getContext();
- llvm::Function *fn =
- llvm::Intrinsic::getOrInsertDeclaration(module, llvm::Intrinsic::dbg_label);
- builder.CreateCall(fn, {
- llvm::MetadataAsValue::get(ctx, moduleTranslation.translateDebugInfo($label))
- });
+ llvm::DIBuilder DB(*module);
+ DB.insertLabel(
+ llvm::cast<llvm::DILabel>(moduleTranslation.translateDebugInfo($label)),
+ moduleTranslation.translateLoc(opInst.getLoc(), scope),
+ builder.GetInsertPoint());
}];
let mlirBuilder = [{
DILabelAttr labelAttr = $_label_attr($label);
diff --git a/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp b/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
index 0f675a0a5df5d..611d8d1960e0e 100644
--- a/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
@@ -18,6 +18,7 @@
#include "mlir/Target/LLVMIR/ModuleTranslation.h"
#include "llvm/ADT/TypeSwitch.h"
+#include "llvm/IR/DIBuilder.h"
#include "llvm/IR/IRBuilder.h"
#include "llvm/IR/InlineAsm.h"
#include "llvm/IR/Instructions.h"
diff --git a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
index b3a06e2be7fe6..d9aae529d19b6 100644
--- a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
@@ -2407,11 +2407,6 @@ mlir::translateModuleToLLVMIR(Operation *module, llvm::LLVMContext &llvmContext,
if (failed(translator.convertUnresolvedBlockAddress()))
return nullptr;
- // Once we've finished constructing elements in the module, we should convert
- // it to use the debug info format desired by LLVM.
- // See https://llvm.org/docs/RemoveDIsDebugInfo.html
- translator.llvmModule->convertToNewDbgValues();
-
// Add the necessary debug info module flags, if they were not encoded in MLIR
// beforehand.
translator.debugTranslation->addModuleFlagsIfNotPresent();
|
|
@llvm/pr-subscribers-mlir-llvm Author: Abid Qadeer (abidh) ChangesCurrently the The conversion is relatively simple but there is a bit of code repetition due to how the APIs in the As the output remains the same, the existing tests cover this change. I also ran the Full diff: https://github.com/llvm/llvm-project/pull/154926.diff 3 Files Affected:
diff --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
index 5e2461b4508e4..f964eb079a725 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
+++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
@@ -673,22 +673,6 @@ def LLVM_CoroPromiseOp : LLVM_IntrOp<"coro.promise", [], [], [], 1> {
class LLVM_DbgIntrOp<string name, string argName, list<Trait> traits = []>
: LLVM_IntrOp<name, [], [], traits, 0> {
- let llvmBuilder = [{
- // Debug intrinsics without debug locations are invalid.
- if(!builder.getCurrentDebugLocation())
- return success();
- llvm::Module *module = builder.GetInsertBlock()->getModule();
- llvm::LLVMContext &ctx = module->getContext();
- llvm::Function *fn =
- llvm::Intrinsic::getOrInsertDeclaration(module, llvm::Intrinsic::}]
- # !subst(".", "_", name) # [{);
- builder.CreateCall(fn, {
- llvm::MetadataAsValue::get(ctx,
- llvm::ValueAsMetadata::get(moduleTranslation.lookupValue(opInst.getOperand(0)))),
- llvm::MetadataAsValue::get(ctx, moduleTranslation.translateDebugInfo($varInfo)),
- llvm::MetadataAsValue::get(ctx, moduleTranslation.translateExpression($locationExpr)),
- });
- }];
let mlirBuilder = [{
// Add debug intrindic to the list of intrinsics that need to be converted once the
// full function was converted.
@@ -711,6 +695,28 @@ def LLVM_DbgDeclareOp : LLVM_DbgIntrOp<"dbg.declare", "addr", [
LLVM_DILocalVariableAttr:$varInfo,
DefaultValuedAttr<LLVM_DIExpressionAttr, "{}">:$locationExpr
);
+ let llvmBuilder = [{
+ // Debug intrinsics without debug locations are invalid.
+ if(!builder.getCurrentDebugLocation())
+ return success();
+ llvm::Function *parentFn = builder.GetInsertBlock()->getParent();
+ llvm::DILocalScope *scope;
+ if (auto scopeLoc =
+ opInst.getLoc()->findInstanceOf<FusedLocWith<LLVM::DIScopeAttr>>())
+ scope = llvm::cast<llvm::DILocalScope>(
+ moduleTranslation.translateDebugInfo(scopeLoc.getMetadata()));
+ else
+ scope = parentFn->getSubprogram();
+
+ llvm::Module *module = builder.GetInsertBlock()->getModule();
+ llvm::DIBuilder DB(*module);
+ DB.insertDeclare(moduleTranslation.lookupValue(opInst.getOperand(0)),
+ llvm::cast<llvm::DILocalVariable>(
+ moduleTranslation.translateDebugInfo($varInfo)),
+ moduleTranslation.translateExpression($locationExpr),
+ moduleTranslation.translateLoc(opInst.getLoc(), scope),
+ builder.GetInsertPoint());
+ }];
}
def LLVM_DbgValueOp : LLVM_DbgIntrOp<"dbg.value", "value",
@@ -721,6 +727,29 @@ def LLVM_DbgValueOp : LLVM_DbgIntrOp<"dbg.value", "value",
LLVM_DILocalVariableAttr:$varInfo,
DefaultValuedAttr<LLVM_DIExpressionAttr, "{}">:$locationExpr
);
+ let llvmBuilder = [{
+ // Debug intrinsics without debug locations are invalid.
+ if(!builder.getCurrentDebugLocation())
+ return success();
+ llvm::Function *parentFn = builder.GetInsertBlock()->getParent();
+ llvm::DILocalScope *scope;
+ if (auto scopeLoc =
+ opInst.getLoc()->findInstanceOf<FusedLocWith<LLVM::DIScopeAttr>>())
+ scope = llvm::cast<llvm::DILocalScope>(
+ moduleTranslation.translateDebugInfo(scopeLoc.getMetadata()));
+ else
+ scope = parentFn->getSubprogram();
+
+ llvm::Module *module = builder.GetInsertBlock()->getModule();
+ llvm::DIBuilder DB(*module);
+ DB.insertDbgValueIntrinsic(
+ moduleTranslation.lookupValue(opInst.getOperand(0)),
+ llvm::cast<llvm::DILocalVariable>(
+ moduleTranslation.translateDebugInfo($varInfo)),
+ moduleTranslation.translateExpression($locationExpr),
+ moduleTranslation.translateLoc(opInst.getLoc(), scope),
+ builder.GetInsertPoint());
+ }];
}
def LLVM_DbgLabelOp : LLVM_IntrOp<"dbg.label", [], [], [], 0> {
@@ -730,13 +759,21 @@ def LLVM_DbgLabelOp : LLVM_IntrOp<"dbg.label", [], [], [], 0> {
// Debug intrinsics without debug locations are invalid.
if(!builder.getCurrentDebugLocation())
return success();
+ llvm::Function *parentFn = builder.GetInsertBlock()->getParent();
+ llvm::DILocalScope *scope;
+ if (auto scopeLoc =
+ opInst.getLoc()->findInstanceOf<FusedLocWith<LLVM::DIScopeAttr>>())
+ scope = llvm::cast<llvm::DILocalScope>(
+ moduleTranslation.translateDebugInfo(scopeLoc.getMetadata()));
+ else
+ scope = parentFn->getSubprogram();
+
llvm::Module *module = builder.GetInsertBlock()->getModule();
- llvm::LLVMContext &ctx = module->getContext();
- llvm::Function *fn =
- llvm::Intrinsic::getOrInsertDeclaration(module, llvm::Intrinsic::dbg_label);
- builder.CreateCall(fn, {
- llvm::MetadataAsValue::get(ctx, moduleTranslation.translateDebugInfo($label))
- });
+ llvm::DIBuilder DB(*module);
+ DB.insertLabel(
+ llvm::cast<llvm::DILabel>(moduleTranslation.translateDebugInfo($label)),
+ moduleTranslation.translateLoc(opInst.getLoc(), scope),
+ builder.GetInsertPoint());
}];
let mlirBuilder = [{
DILabelAttr labelAttr = $_label_attr($label);
diff --git a/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp b/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
index 0f675a0a5df5d..611d8d1960e0e 100644
--- a/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
@@ -18,6 +18,7 @@
#include "mlir/Target/LLVMIR/ModuleTranslation.h"
#include "llvm/ADT/TypeSwitch.h"
+#include "llvm/IR/DIBuilder.h"
#include "llvm/IR/IRBuilder.h"
#include "llvm/IR/InlineAsm.h"
#include "llvm/IR/Instructions.h"
diff --git a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
index b3a06e2be7fe6..d9aae529d19b6 100644
--- a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
@@ -2407,11 +2407,6 @@ mlir::translateModuleToLLVMIR(Operation *module, llvm::LLVMContext &llvmContext,
if (failed(translator.convertUnresolvedBlockAddress()))
return nullptr;
- // Once we've finished constructing elements in the module, we should convert
- // it to use the debug info format desired by LLVM.
- // See https://llvm.org/docs/RemoveDIsDebugInfo.html
- translator.llvmModule->convertToNewDbgValues();
-
// Add the necessary debug info module flags, if they were not encoded in MLIR
// beforehand.
translator.debugTranslation->addModuleFlagsIfNotPresent();
|
| @@ -711,6 +695,28 @@ def LLVM_DbgDeclareOp : LLVM_DbgIntrOp<"dbg.declare", "addr", [ | |||
| LLVM_DILocalVariableAttr:$varInfo, | |||
| DefaultValuedAttr<LLVM_DIExpressionAttr, "{}">:$locationExpr | |||
| ); | |||
| let llvmBuilder = [{ | |||
| // Debug intrinsics without debug locations are invalid. | |||
There was a problem hiding this comment.
May as well update the terminology while passing by.
| // Debug intrinsics without debug locations are invalid. | |
| // Debug records without debug locations are invalid. |
There was a problem hiding this comment.
The change makes sense!
Let's try to factor out some helpers to reduce the code duplication.
The casts are probably unavoidable. If there a place where the cast could fail we may want to use dyn_cast and return failure to have a better error handling. However, it sounds like refactoring the inheritance to match LLVM will fix the critical case?
| llvm::DILocalScope *scope; | ||
| if (auto scopeLoc = | ||
| opInst.getLoc()->findInstanceOf<FusedLocWith<LLVM::DIScopeAttr>>()) | ||
| scope = llvm::cast<llvm::DILocalScope>( | ||
| moduleTranslation.translateDebugInfo(scopeLoc.getMetadata())); | ||
| else | ||
| scope = parentFn->getSubprogram(); |
There was a problem hiding this comment.
Since it is not possible anymore to put all the builder code in the debug intrinsic base class there is quite a bit of code duplication. Can you factor out some of this code into a helper function(s) placed in LLVMDialect.cpp? One thing that seems doable is to extract a helper for the scope computation but there may be other options as well. I would place it somewhere to the other intrinsic functionality that has been factored out (e.g. here
).That should reduce code duplication and the amount of C++ embedded in tablegen.
There was a problem hiding this comment.
Thanks for your suggestion. I have moved the code in a separate function. I initially used the location that you suggested for the new function but it would have required to add its declaration in LLVMDialect.h and then at least a forward declaration of ModuleTranslation there. It seemed like too much churn for a local helper. I have instead added in LLVMToLLVMIRTranslation.cpp.
I also changed the code to use dyn_cast.
| scope = parentFn->getSubprogram(); | ||
|
|
||
| llvm::Module *module = builder.GetInsertBlock()->getModule(); | ||
| llvm::DIBuilder DB(*module); |
There was a problem hiding this comment.
| llvm::DIBuilder DB(*module); | |
| llvm::DIBuilder debugInfoBuilder(*module); |
nit: local variables should start with a lower case letter. Let's maybe use debugInfoBuilder or similar?
| let llvmBuilder = [{ | ||
| // Debug intrinsics without debug locations are invalid. | ||
| if(!builder.getCurrentDebugLocation()) | ||
| return success(); |
There was a problem hiding this comment.
Would it be reasonable to report an error here? If this is "invalid" as the comment says, silently ignoring it doesn't seem like the right behavior.
There was a problem hiding this comment.
I agree with this comment. I can change this in a separate PR.
| @@ -673,22 +673,6 @@ def LLVM_CoroPromiseOp : LLVM_IntrOp<"coro.promise", [], [], [], 1> { | |||
|
|
|||
| class LLVM_DbgIntrOp<string name, string argName, list<Trait> traits = []> | |||
There was a problem hiding this comment.
| class LLVM_DbgIntrOp<string name, string argName, list<Trait> traits = []> | |
| class LLVM_DbgRecordOp<string name, string argName, list<Trait> traits = []> |
There was a problem hiding this comment.
I am not sure about this. The mlir representation remains the same. It is just that mlir InrtOp now translates to dbg records instead of debug intrinsics in llvm.
There was a problem hiding this comment.
Yeah I would stick to LLVM_DbgIntrOp since they are effectively still intrinsics in MLIR.
There was a problem hiding this comment.
In what sense are they intrinsics in MLIR? I didn't think MLIR had a concept of intrinsics beyond having a way to represent calls to LLVM IR intrinsics.
This is obviously a minor point and I don't have a problem with the change going in either way. I just want to make sure I'm not missing something.
There was a problem hiding this comment.
Oh, I see. It's still deriving from LLVM_IntrOp<> and the name will still be "llvm.intr.dbg.*". That feels like less of a minor point to me. I think there's more going on here than I realized, such as the call to moduleImport.addDebugIntrinsic in the mlirBuilder which is apparently processing this as a CallInst (while importing LLVM IR?).
Will something have to be done later to import debug records?
There was a problem hiding this comment.
You are correct that MLIR does not have the concept of an intrinsic. However, LLVM dialect still models intrinsics, using operations, and it doesn't have the equivalent of debug records. Ideally, a debug record would not be an MLIR operation, but some sort of Location attribute attached to an operation. Unfortunately, MLIR Locations cannot depend on values which would be necessary for debug records if I understand them correctly.
TD;LR we will need to come up with a modeling for debug records. Ideally, this would be done with MLIR's Location infrastructure, but I fear we will have to stick to operations.
There was a problem hiding this comment.
Yes, there's definitely a difficulty mapping debug records to MLIR constructs. I'm fine with this implementation if it's just seen as a temporary step along the way to a better handling of debug records, though this artificial link to intrinsic calls makes me uneasy.
There was a problem hiding this comment.
Yes I agree that this has to change. We just miss volunteers to implement this. There is a ticket for this (#129121)
1. Refactor some code into a separate function to avoid duplication. 2. Some name and comments update.
As I wrote in the PR description, the output remains the same. It is just that intermediate use of llvm intrinsics have been removed. So all the existing tests check this functionality. |
mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Tobias Gysi <tobias.gysi@nextsilicon.com>
| @@ -673,22 +673,6 @@ def LLVM_CoroPromiseOp : LLVM_IntrOp<"coro.promise", [], [], [], 1> { | |||
|
|
|||
| class LLVM_DbgIntrOp<string name, string argName, list<Trait> traits = []> | |||
There was a problem hiding this comment.
Yes, there's definitely a difficulty mapping debug records to MLIR constructs. I'm fine with this implementation if it's just seen as a temporary step along the way to a better handling of debug records, though this artificial link to intrinsic calls makes me uneasy.
Currently the
DbgDeclareOP/DbgValueOP/DbgLabelOpare first converted to llvm debug intrinsics which are later translated to debug records by a call ofconvertToNewDbgValues. This is not only inefficient but also makes the code that works on intermediate IR unnecessarily complicated. The debug intrinsics are also being phased out. This PR converts these Ops directly to debug records.The conversion is relatively simple but there is a bit of code repetition due to how the APIs in the
DIBuildersare named. There are fewcast<>which I would like to do without but could not see a good way around them. Any suggestions welcome here. Also noticed thatDISubprogramAttris inherited fromDIScopeAttrwhile in llvm, theDISubprograminherits fromDILocalScope. I am going to fix this separately and then we could useFusedLocWith<LLVM::DILocalScopeAttr>and cast toDILocalScopewill be much safer.As the output remains the same, the existing tests cover this change. I also ran the
GDBtests with flang and there was no regression.