[flang][OpenMP] Fix typos in diagnostic messages, NFC #154953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-flang-semantics Author: Krzysztof Parzyszek (kparzysz) ChangesFull diff: https://github.com/llvm/llvm-project/pull/154953.diff 2 Files Affected:
diff --git a/flang/lib/Semantics/check-omp-structure.cpp b/flang/lib/Semantics/check-omp-structure.cpp
index 142423b16334f..5967a18460002 100644
--- a/flang/lib/Semantics/check-omp-structure.cpp
+++ b/flang/lib/Semantics/check-omp-structure.cpp
@@ -1198,13 +1198,13 @@ void OmpStructureChecker::Enter(const parser::OpenMPGroupprivate &x) {
if (sym->has<AssocEntityDetails>()) {
context_.SayWithDecl(*sym, arg.source,
- "GROUPPRIVATE argument cannot be an an ASSOCIATE name"_err_en_US);
+ "GROUPPRIVATE argument cannot be an ASSOCIATE name"_err_en_US);
continue;
}
if (auto *obj{sym->detailsIf<ObjectEntityDetails>()}) {
if (obj->IsCoarray()) {
context_.Say(arg.source,
- "GROUPPRIVATE argument cannot be an a coarray"_err_en_US);
+ "GROUPPRIVATE argument cannot be a coarray"_err_en_US);
continue;
}
if (obj->init()) {
@@ -1215,7 +1215,7 @@ void OmpStructureChecker::Enter(const parser::OpenMPGroupprivate &x) {
}
if (sym->test(Symbol::Flag::InCommonBlock)) {
context_.Say(arg.source,
- "GROUPPRIVATE argument cannot be an a member of a common block"_err_en_US);
+ "GROUPPRIVATE argument cannot be a member of a common block"_err_en_US);
continue;
}
if (!IsCommonBlock(*sym)) {
diff --git a/flang/test/Semantics/OpenMP/groupprivate.f90 b/flang/test/Semantics/OpenMP/groupprivate.f90
index 89afffd9dff65..a875c466111a3 100644
--- a/flang/test/Semantics/OpenMP/groupprivate.f90
+++ b/flang/test/Semantics/OpenMP/groupprivate.f90
@@ -14,7 +14,7 @@ subroutine f00
integer, save :: y
associate (z => y)
block
- !ERROR: GROUPPRIVATE argument cannot be an an ASSOCIATE name
+ !ERROR: GROUPPRIVATE argument cannot be an ASSOCIATE name
!$omp groupprivate(z)
end block
end associate
@@ -25,7 +25,7 @@ module m01
implicit none
integer :: x, y
common /some_block/ x
-!ERROR: GROUPPRIVATE argument cannot be an a member of a common block
+!ERROR: GROUPPRIVATE argument cannot be a member of a common block
!$omp groupprivate(x)
contains
@@ -42,6 +42,6 @@ subroutine f01
module m02
implicit none
integer :: x(10)[*]
-!ERROR: GROUPPRIVATE argument cannot be an a coarray
+!ERROR: GROUPPRIVATE argument cannot be a coarray
!$omp groupprivate(x)
end module
|
|
@llvm/pr-subscribers-flang-openmp Author: Krzysztof Parzyszek (kparzysz) ChangesFull diff: https://github.com/llvm/llvm-project/pull/154953.diff 2 Files Affected:
diff --git a/flang/lib/Semantics/check-omp-structure.cpp b/flang/lib/Semantics/check-omp-structure.cpp
index 142423b16334f..5967a18460002 100644
--- a/flang/lib/Semantics/check-omp-structure.cpp
+++ b/flang/lib/Semantics/check-omp-structure.cpp
@@ -1198,13 +1198,13 @@ void OmpStructureChecker::Enter(const parser::OpenMPGroupprivate &x) {
if (sym->has<AssocEntityDetails>()) {
context_.SayWithDecl(*sym, arg.source,
- "GROUPPRIVATE argument cannot be an an ASSOCIATE name"_err_en_US);
+ "GROUPPRIVATE argument cannot be an ASSOCIATE name"_err_en_US);
continue;
}
if (auto *obj{sym->detailsIf<ObjectEntityDetails>()}) {
if (obj->IsCoarray()) {
context_.Say(arg.source,
- "GROUPPRIVATE argument cannot be an a coarray"_err_en_US);
+ "GROUPPRIVATE argument cannot be a coarray"_err_en_US);
continue;
}
if (obj->init()) {
@@ -1215,7 +1215,7 @@ void OmpStructureChecker::Enter(const parser::OpenMPGroupprivate &x) {
}
if (sym->test(Symbol::Flag::InCommonBlock)) {
context_.Say(arg.source,
- "GROUPPRIVATE argument cannot be an a member of a common block"_err_en_US);
+ "GROUPPRIVATE argument cannot be a member of a common block"_err_en_US);
continue;
}
if (!IsCommonBlock(*sym)) {
diff --git a/flang/test/Semantics/OpenMP/groupprivate.f90 b/flang/test/Semantics/OpenMP/groupprivate.f90
index 89afffd9dff65..a875c466111a3 100644
--- a/flang/test/Semantics/OpenMP/groupprivate.f90
+++ b/flang/test/Semantics/OpenMP/groupprivate.f90
@@ -14,7 +14,7 @@ subroutine f00
integer, save :: y
associate (z => y)
block
- !ERROR: GROUPPRIVATE argument cannot be an an ASSOCIATE name
+ !ERROR: GROUPPRIVATE argument cannot be an ASSOCIATE name
!$omp groupprivate(z)
end block
end associate
@@ -25,7 +25,7 @@ module m01
implicit none
integer :: x, y
common /some_block/ x
-!ERROR: GROUPPRIVATE argument cannot be an a member of a common block
+!ERROR: GROUPPRIVATE argument cannot be a member of a common block
!$omp groupprivate(x)
contains
@@ -42,6 +42,6 @@ subroutine f01
module m02
implicit none
integer :: x(10)[*]
-!ERROR: GROUPPRIVATE argument cannot be an a coarray
+!ERROR: GROUPPRIVATE argument cannot be a coarray
!$omp groupprivate(x)
end module
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.