[MC] AsmLexer invalid read fix. #154972
Open
[MC] AsmLexer invalid read fix. #154972
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsmLexer::LexToken() switch statement contains a loop that's meant to skip past indentation. This loop however doesn't check if CurPtr is at the end of CurBuf before dereferencing. This can cause an issue with invalid reads. This commit adds a condition `CurPtr != CurBuf.end()` to ensure no invalid reads will be made.
|
Need a llvm/test/MC/AsmParser test to confirm we actually have the out-of-bounds error and fix it. |
|
Note self: need to create a binary file which will end with 0x20 (space character) and another file that will contain the commands to run the test. Possibly put |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsmLexer::LexToken() switch statement contains a loop that's meant to
skip past indentation. This loop however doesn't check if CurPtr is at
the end of CurBuf before dereferencing. This can cause an issue with
invalid reads.
This commit adds a condition
CurPtr != CurBuf.end()to ensure noinvalid reads will be made.