Skip to content

Conversation

jurahul
Copy link
Contributor

@jurahul jurahul commented Aug 22, 2025

Rearrange decode functions to be before including the generated disassembler code and eliminate forward declarations for most of them. This is possible because fieldFromInstruction is now in MCDecoder.h and not in the generated disassembler code.

@jurahul jurahul marked this pull request as ready for review August 22, 2025 19:32
Copy link
Contributor

@s-barannikov s-barannikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@benshi001 benshi001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jurahul jurahul merged commit 69b9459 into llvm:main Aug 25, 2025
12 checks passed
@jurahul jurahul deleted the nfc_avr_disasm_move_decoder_funcs branch August 25, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants