[ADT] Simplify SmallDenseMap::swap (NFC) #155067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch simplifies the swapping of *getLargeRep(). In other places, we treat the two member variables together like: new (getLargeRep()) LargeRep(allocateBuckets(InitBuckets)); This patch makes the code a little more consistent with other places copying/moving LargeRep.
|
@llvm/pr-subscribers-llvm-adt Author: Kazu Hirata (kazutakahirata) ChangesThis patch simplifies the swapping of *getLargeRep(). In other places, we treat the two member variables together like: new (getLargeRep()) LargeRep(allocateBuckets(InitBuckets)); This patch makes the code a little more consistent with other places Full diff: https://github.com/llvm/llvm-project/pull/155067.diff 1 Files Affected:
diff --git a/llvm/include/llvm/ADT/DenseMap.h b/llvm/include/llvm/ADT/DenseMap.h
index 2a35c3d583f70..156894aa7f0e3 100644
--- a/llvm/include/llvm/ADT/DenseMap.h
+++ b/llvm/include/llvm/ADT/DenseMap.h
@@ -1038,8 +1038,7 @@ class SmallDenseMap
return;
}
if (!Small && !RHS.Small) {
- std::swap(getLargeRep()->Buckets, RHS.getLargeRep()->Buckets);
- std::swap(getLargeRep()->NumBuckets, RHS.getLargeRep()->NumBuckets);
+ std::swap(*getLargeRep(), *RHS.getLargeRep());
return;
}
|
tgymnich
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simplifies the swapping of *getLargeRep().
In other places, we treat the two member variables together like:
new (getLargeRep()) LargeRep(allocateBuckets(InitBuckets));
This patch makes the code a little more consistent with other places
copying/moving LargeRep.