-
Notifications
You must be signed in to change notification settings - Fork 14.9k
[clang] Remove redundant control flow statements (NFC) #155138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clang] Remove redundant control flow statements (NFC) #155138
Conversation
@llvm/pr-subscribers-hlsl @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes
Full diff: https://github.com/llvm/llvm-project/pull/155138.diff 4 Files Affected:
diff --git a/clang/lib/CodeGen/Targets/RISCV.cpp b/clang/lib/CodeGen/Targets/RISCV.cpp
index cbb0255fdb03a..264595a6e4b76 100644
--- a/clang/lib/CodeGen/Targets/RISCV.cpp
+++ b/clang/lib/CodeGen/Targets/RISCV.cpp
@@ -955,7 +955,6 @@ void RISCVABIInfo::createCoercedStore(llvm::Value *Val, Address Dst,
cast<llvm::FixedVectorType>(EltTy), Val, uint64_t(0));
auto *I = CGF.Builder.CreateStore(Coerced, Dst, DestIsVolatile);
CGF.addInstToCurrentSourceAtom(I, Val);
- return;
}
namespace {
diff --git a/clang/lib/Driver/Driver.cpp b/clang/lib/Driver/Driver.cpp
index d682ffc832c83..34eaad43d6f79 100644
--- a/clang/lib/Driver/Driver.cpp
+++ b/clang/lib/Driver/Driver.cpp
@@ -4672,7 +4672,6 @@ void Driver::BuildDriverManagedModuleBuildActions(
Compilation &C, llvm::opt::DerivedArgList &Args, const InputList &Inputs,
ActionList &Actions) const {
Diags.Report(diag::remark_performing_driver_managed_module_build);
- return;
}
/// Returns the canonical name for the offloading architecture when using a HIP
diff --git a/clang/lib/Driver/ToolChains/HLSL.cpp b/clang/lib/Driver/ToolChains/HLSL.cpp
index 4fedb5dd0ac40..eaa7d736719b5 100644
--- a/clang/lib/Driver/ToolChains/HLSL.cpp
+++ b/clang/lib/Driver/ToolChains/HLSL.cpp
@@ -215,7 +215,6 @@ void getSpirvExtOperand(StringRef SpvExtensionArg, raw_ostream &out) {
return;
}
out << SpvExtensionArg;
- return;
}
SmallString<1024> getSpirvExtArg(ArrayRef<std::string> SpvExtensionArgs) {
diff --git a/clang/unittests/Analysis/FlowSensitive/FormulaTest.cpp b/clang/unittests/Analysis/FlowSensitive/FormulaTest.cpp
index cabcd59fffedc..db9c02854c7fa 100644
--- a/clang/unittests/Analysis/FlowSensitive/FormulaTest.cpp
+++ b/clang/unittests/Analysis/FlowSensitive/FormulaTest.cpp
@@ -22,8 +22,6 @@ using namespace dataflow;
using ::llvm::Failed;
using ::llvm::HasValue;
using ::llvm::Succeeded;
-using ::testing::ElementsAre;
-using ::testing::IsEmpty;
class SerializeFormulaTest : public ::testing::Test {
protected:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title needs to be more specific.
Oops. Thank you for pointing this out. |
No description provided.