[Clang-Repl] Sinking RemoteJITUtils into Interpreter class(Refactoring) #155140
+531
−369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into redirection
vgvassilev
reviewed
Aug 25, 2025
Comment on lines
+334
to
+337
| if (::OffloadArch.empty()) { | ||
| ::OffloadArch = "sm_35"; | ||
| } | ||
| CB.SetOffloadArch(OffloadArch); | ||
| CB.SetOffloadArch(::OffloadArch); |
There was a problem hiding this comment.
Are these changes relevant to the current PR?
There was a problem hiding this comment.
yes. if not done, it gives following error:
error: reference to 'OffloadArch' is ambiguousThere was a problem hiding this comment.
Which compiler is this? Why it works upstream?
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
vgvassilev
reviewed
Aug 25, 2025
vgvassilev
reviewed
Aug 25, 2025
vgvassilev
reviewed
Aug 26, 2025
vgvassilev
reviewed
Aug 28, 2025
| bool UseSharedMemory; | ||
|
|
||
| /// String representing the slab allocation size for memory management. | ||
| std::string SlabAllocateSizeString; |
There was a problem hiding this comment.
This should be an unsigned int I think. All of these should have good default values.
There was a problem hiding this comment.
Actually this has to be string. this is how it is handled:
static llvm::cl::opt<std::string> SlabAllocateSizeString(
"slab-allocate",
llvm::cl::desc("Allocate from a slab of the given size "
"(allowable suffixes: Kb, Mb, Gb. default = "
"Kb)"),
llvm::cl::init(""), llvm::cl::cat(OOPCategory));
it has suffix
There was a problem hiding this comment.
We can transform it before putting it in the config.
Comment on lines
+334
to
+337
| if (::OffloadArch.empty()) { | ||
| ::OffloadArch = "sm_35"; | ||
| } | ||
| CB.SetOffloadArch(OffloadArch); | ||
| CB.SetOffloadArch(::OffloadArch); |
There was a problem hiding this comment.
Which compiler is this? Why it works upstream?
added 2 commits
August 31, 2025 23:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring PR. It sinks RemoteJITUtils into Interpreter and IncrementalExecutor classes.