[mlir] Fix bug in PDLL Parser #155243
Merged
[mlir] Fix bug in PDLL Parser #155243
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts changes made to `mlir/lib/Tools/PDLL/Parser/Parser.cpp` in 095b41c . `raw_indented_ostream::printReindented()` reads from a string to which it also concurrently writes to, causing unintended behavior. Credits to @jackalcooper for finding the issue.
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-core Author: Youngsuk Kim (JOE1994) ChangesThis reverts changes made to
Credits to @jackalcooper for finding the issue. Full diff: https://github.com/llvm/llvm-project/pull/155243.diff 1 Files Affected:
diff --git a/mlir/lib/Tools/PDLL/Parser/Parser.cpp b/mlir/lib/Tools/PDLL/Parser/Parser.cpp
index 51e702a1bb53a..c883baa7be2c5 100644
--- a/mlir/lib/Tools/PDLL/Parser/Parser.cpp
+++ b/mlir/lib/Tools/PDLL/Parser/Parser.cpp
@@ -147,8 +147,9 @@ class Parser {
std::string docStr;
{
llvm::raw_string_ostream docOS(docStr);
+ std::string tmpDocStr = doc.str();
raw_indented_ostream(docOS).printReindented(
- StringRef(docStr).rtrim(" \t"));
+ StringRef(tmpDocStr).rtrim(" \t"));
}
return docStr;
}
|
JOE1994
referenced
this pull request
Aug 25, 2025
Excluded updates to mlir/lib/AsmParser/Parser.cpp , which caused LIT failure "FAIL: MLIR::completion.test" on multiple buildbots.
j2kun
approved these changes
Aug 25, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/16195 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts changes made to
mlir/lib/Tools/PDLL/Parser/Parser.cppin 095b41c .raw_indented_ostream::printReindented()reads from a string to which it also concurrently writes to, causing unintended behavior.Credits to @jackalcooper for finding the issue.