Skip to content

Conversation

mingmingl-llvm
Copy link
Contributor

TODO: regression test coverage.

mingmingl-llvm added a commit that referenced this pull request Aug 28, 2025
…to partition data (#151238)

f3f2832
introduces the data access profile format as a payload inside
[memprof](https://llvm.org/docs/InstrProfileFormat.html#memprof-profile-data),
and the MemProfUse pass reads the memprof payload.

This change extends the MemProfUse pass to read the data access profiles
to annotate global variables' section prefix.
1. If there are samples for a global variable, it's annotated as hot.
2. If a global variable is seen in the profiled binary file but doesn't
have access samples, it's annotated as unlikely.

Introduce an option `annotate-static-data-prefix` to flag-gate the
global-variable annotation path, and make it false by default.
#155337 is the (WIP) draft
change to "reconcile" two sources of hotness.
Base automatically changed from users/mingmingl-llvm/memprofuse to main August 28, 2025 03:43
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Aug 28, 2025
…s profiles to partition data (#151238)

llvm/llvm-project@f3f2832
introduces the data access profile format as a payload inside
[memprof](https://llvm.org/docs/InstrProfileFormat.html#memprof-profile-data),
and the MemProfUse pass reads the memprof payload.

This change extends the MemProfUse pass to read the data access profiles
to annotate global variables' section prefix.
1. If there are samples for a global variable, it's annotated as hot.
2. If a global variable is seen in the profiled binary file but doesn't
have access samples, it's annotated as unlikely.

Introduce an option `annotate-static-data-prefix` to flag-gate the
global-variable annotation path, and make it false by default.
llvm/llvm-project#155337 is the (WIP) draft
change to "reconcile" two sources of hotness.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant