[Triple] Add target triple support for CheriotRTOS. #155374
Conversation
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
For context, CheriotRTOS is a custom RTOS co-designed for the CHERIoT CHERI-enabled RISCV32E platform. It uses a custom ABI and linkage model, necesitating representing it in the target triple.
|
@jrtc27 @arichardson for visibility |
| .StartsWith("serenity", Triple::Serenity) | ||
| .StartsWith("vulkan", Triple::Vulkan) | ||
| .Default(Triple::UnknownOS); | ||
| .StartsWith("darwin", Triple::Darwin) |
There was a problem hiding this comment.
I wonder if it would make sense to have a separate NFC PR to clang-format Triple.cpp?
LLVM is quite inconsistent with switch statements though... The clang-format coding style requires a newline, but there are lots of short switch statements that use the one-line style. And then some of them are manually aligned and others aren't...
There was a problem hiding this comment.
❯ git grep -E '^\s*case\s+.+((return.*;)|(break;))$' lib | wc -l
6733
❯ git grep -E '^\s*case\s+.:$' lib | wc -l
1102
It looks like the short case on a line is actually more common than the longer form, so maybe there should be a RFC to update the clang-format style to something like this
AllowShortCaseLabelsOnASingleLine: true
AlignConsecutiveShortCaseStatements:
Enabled: true
AcrossEmptyLines: true
AcrossComments: true
AlignCaseColons: false
There was a problem hiding this comment.
Ah looks like this was discussed back in 2022: https://discourse.llvm.org/t/enable-single-line-case-statements-in-llvm-clang-format-style/61062
For context, CheriotRTOS is a custom RTOS co-designed for the CHERIoT
CHERI-enabled RISCV32E platform. It uses a custom ABI and linkage model,
necesitating representing it in the target triple.