Skip to content

[OpenMP][ompTest] Guard installation of all components #155433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

[OpenMP][ompTest] Guard installation of all components #155433

merged 1 commit into from
Aug 27, 2025

Conversation

mhalk
Copy link
Contributor

@mhalk mhalk commented Aug 26, 2025

Make installation of ompTest optional via:
-DLIBOMPTEST_INSTALL_COMPONENTS=ON (default: OFF)

@llvmbot llvmbot added openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime labels Aug 26, 2025
@mhalk mhalk requested review from nikic, jprotze and jplehr August 26, 2025 15:16
@mhalk mhalk mentioned this pull request Aug 26, 2025
Merged
jprotze
jprotze reviewed Aug 26, 2025
View reviewed changes
@mhalk
[OpenMP][ompTest] Guard installation of all components
8100f14 
Make installation of ompTest optional via:
-DLIBOMPTEST_INSTALL_COMPONENTS=ON (default: OFF)
@mhalk mhalk force-pushed the mhalk/fix/omptest-install-on-request-only branch from 5d81bc8 to 8100f14 Compare August 26, 2025 15:45
mhalk added a commit to mhalk/aomp that referenced this pull request Aug 26, 2025
@mhalk
[OpenMP][omptest] Adopt omptest installation guard into scripts
ed7b760 
Enable installation of omptest for 'project' and 'openmp' components by default.
See: llvm/llvm-project#155433
@mhalk mhalk mentioned this pull request Aug 26, 2025
Merged
jplehr
jplehr reviewed Aug 27, 2025
View reviewed changes
Copy link
Contributor

@jplehr jplehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.
Let's wait for others to accept.

nikic
nikic approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jprotze
jprotze approved these changes Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@jprotze jprotze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jplehr jplehr merged commit c5e1ac4 into llvm:main Aug 27, 2025
9 checks passed
@mhalk mhalk deleted the mhalk/fix/omptest-install-on-request-only branch August 27, 2025 12:22
@llvm-ci
Copy link
Collaborator

llvm-ci commented Aug 27, 2025

LLVM Buildbot has detected a new failure on builder openmp-s390x-linux running on systemz-1 while building openmp at step 6 "test-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/15459

Here is the relevant piece of the build log for the reference 
Step 6 (test-openmp) failure: test (failure)
******************** TEST 'libomp :: tasking/issue-94260-2.c' FAILED ********************
Exit Code: -11

Command Output (stdout):
--
# RUN: at line 1
/home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/./bin/clang -fopenmp   -I /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -I /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.src/openmp/runtime/test -L /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/runtimes/runtimes-bins/openmp/runtime/src  -fno-omit-frame-pointer -mbackchain -I /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.src/openmp/runtime/test/ompt /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.src/openmp/runtime/test/tasking/issue-94260-2.c -o /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/runtimes/runtimes-bins/openmp/runtime/test/tasking/Output/issue-94260-2.c.tmp -lm -latomic && /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/runtimes/runtimes-bins/openmp/runtime/test/tasking/Output/issue-94260-2.c.tmp
# executed command: /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/./bin/clang -fopenmp -I /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -I /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.src/openmp/runtime/test -L /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -fno-omit-frame-pointer -mbackchain -I /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.src/openmp/runtime/test/ompt /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.src/openmp/runtime/test/tasking/issue-94260-2.c -o /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/runtimes/runtimes-bins/openmp/runtime/test/tasking/Output/issue-94260-2.c.tmp -lm -latomic
# executed command: /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/runtimes/runtimes-bins/openmp/runtime/test/tasking/Output/issue-94260-2.c.tmp
# note: command had no output on stdout or stderr
# error: command failed with exit status: -11

--

********************

@mhalk
Copy link
Contributor Author

mhalk commented Aug 28, 2025

Checked the buildbot fail and it seems like libomp :: tasking/issue-94260-2.c is flaky.

See other previous builds on that bot:
https://lab.llvm.org/buildbot/#/builders/88/builds/15362
https://lab.llvm.org/buildbot/#/builders/88/builds/15401
https://lab.llvm.org/buildbot/#/builders/88/builds/15430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplehr jplehr jplehr left review comments

@nikic nikic nikic approved these changes

@jprotze jprotze jprotze approved these changes

Assignees
No one assigned
Labels
openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mhalk @llvm-ci @nikic @jprotze @jplehr @llvmbot