[Flang-RT][OpenMP] Define _GLIBCXX_NO_ASSERTIONS #155440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpalermo
approved these changes
Aug 27, 2025
jprotze
reviewed
Aug 27, 2025
| @@ -167,6 +167,7 @@ endif() | |||
|
|
|||
| # Disable libstdc++ assertions, even in an LLVM_ENABLE_ASSERTIONS build, to | |||
| # avoid an unwanted dependency on libstdc++.so. | |||
| add_compile_definitions(_GLIBCXX_NO_ASSERTIONS) | |||
| if(NOT WIN32) | |||
| add_definitions(-U_GLIBCXX_ASSERTIONS) | |||
There was a problem hiding this comment.
Like for flang-rt, I think we also need -U_LIBCPP_ENABLE_ASSERTIONS in libomp
There was a problem hiding this comment.
I think this is unrelated to gcc-mirror/gcc@361d230, should be a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since GCC 15.1, libstdc++ enabled assertions/hardening by default in non-optimized (-O0) builds [1]. That is, _GLIBCXX_ASSERTIONS is defined in the libstdc++ headers itself so defining/undefining it on the compiler command line no longer has an effect in non-optimized builds. As the commit message[2] suggests, define _GLIBCXX_NO_ASSERTIONS instead.
For libstdc++ headers before 15.1, -U_GLIBCXX_ASSERTIONS still has to be on the command line as well.
Defining _GLIBCXX_NO_ASSERTIONS was previously proposed in #152223
[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112808
[2] gcc-mirror/gcc@361d230