[ADT] Implement DenseSetImpl::contains in terms of DenseMap::contains (NFC) #155551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (NFC) DenseSetImpl::contains can directly use DenseMap::contains. While I am at it, this patch moves count() immediately after contains() and annotates both functions with [[nodiscard].
|
@llvm/pr-subscribers-llvm-adt Author: Kazu Hirata (kazutakahirata) ChangesDenseSetImpl::contains can directly use DenseMap::contains. While I am at it, this patch moves count() immediately after Full diff: https://github.com/llvm/llvm-project/pull/155551.diff 1 Files Affected:
diff --git a/llvm/include/llvm/ADT/DenseSet.h b/llvm/include/llvm/ADT/DenseSet.h
index e6051f79d5710..8ba74f6b9f746 100644
--- a/llvm/include/llvm/ADT/DenseSet.h
+++ b/llvm/include/llvm/ADT/DenseSet.h
@@ -97,9 +97,6 @@ class DenseSetImpl {
void clear() { TheMap.clear(); }
- /// Return 1 if the specified key is in the set, 0 otherwise.
- size_type count(const_arg_type_t<ValueT> V) const { return TheMap.count(V); }
-
bool erase(const ValueT &V) { return TheMap.erase(V); }
void swap(DenseSetImpl &RHS) { TheMap.swap(RHS.TheMap); }
@@ -169,8 +166,13 @@ class DenseSetImpl {
}
/// Check if the set contains the given element.
- bool contains(const_arg_type_t<ValueT> V) const {
- return TheMap.find(V) != TheMap.end();
+ [[nodiscard]] bool contains(const_arg_type_t<ValueT> V) const {
+ return TheMap.contains(V);
+ }
+
+ /// Return 1 if the specified key is in the set, 0 otherwise.
+ [[nodiscard]] size_type count(const_arg_type_t<ValueT> V) const {
+ return TheMap.count(V);
}
/// Alternative version of find() which allows a different, and possibly less
|
arsenm
approved these changes
Aug 27, 2025
kuhar
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DenseSetImpl::contains can directly use DenseMap::contains.
While I am at it, this patch moves count() immediately after
contains() and annotates both functions with [[nodiscard].